Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WhenActivated not fired when in ViewModelViewHost #2023

Merged
merged 1 commit into from May 12, 2019

Conversation

Projects
None yet
1 participant
@glennawatson
Copy link
Contributor

commented May 12, 2019

Fixes #2021

@glennawatson glennawatson requested review from reactiveui/core-team as code owners May 12, 2019

@codecov

This comment has been minimized.

Copy link

commented May 12, 2019

Codecov Report

Merging #2023 into master will decrease coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2023      +/-   ##
==========================================
- Coverage   60.78%   60.18%   -0.61%     
==========================================
  Files         115      116       +1     
  Lines        4580     4448     -132     
  Branches      656      638      -18     
==========================================
- Hits         2784     2677     -107     
+ Misses       1614     1598      -16     
+ Partials      182      173       -9
Impacted Files Coverage Δ
src/ReactiveUI/EventManagers/WeakEventManager.cs 60.43% <0%> (-3.33%) ⬇️
src/ReactiveUI/ReactiveCommand/ReactiveCommand.cs 79.32% <0%> (-0.89%) ⬇️
...rvableCollectionChangedToListChangedTransformer.cs 86.66% <0%> (ø)
src/ReactiveUI/Legacy/ReactiveDerivedCollection.cs 40.67% <0%> (+0.4%) ⬆️
...eactiveUI/ReactiveCommand/ReactiveCommandMixins.cs 100% <0%> (+3.77%) ⬆️
...tiveUI/ReactiveObject/IReactiveObjectExtensions.cs 100% <0%> (+4.54%) ⬆️
src/ReactiveUI/Comparers/OrderedComparer.cs 83.33% <0%> (+19.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b78c4...4b22e5f. Read the comment docs.

@glennawatson glennawatson merged commit afdf520 into master May 12, 2019

5 of 6 checks passed

codecov/project 60.18% (-0.61%) compared to f0b78c4
Details
ReactiveUI-CI Build #9.14.4+1e1f48e0ab succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing f0b78c4...4b22e5f
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the issue-2021 branch May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.