Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VS2019 android wire up controls throws exception #2050

Conversation

Projects
None yet
2 participants
@clintonrocksmith
Copy link
Contributor

commented May 24, 2019

What kind of change does this PR introduce?
Bug Fix for #2047

What is the current behavior?
Throws an error in Visual Studio 2019

What is the new behavior?
Does not crash

What might this PR break?
Maybe Bindings, not sure

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

clintonrocksmith and others added some commits May 23, 2019

- Removed the assumption that the array holds a correct list as it's …
…now alphabetical except for mscor.lib

- Changed the assumption to the calling assembly as this is "generally" the Assembly that will want to wire up the controls
Reworked the resolving of the View's
May break if trying to get a resource that does not have any view underneath it.  But then WireUpControls will not work
More mistakes that I missed.
FodyWeavers updated too.  Not sure if we needed that

@clintonrocksmith clintonrocksmith requested review from reactiveui/android-team as code owners May 24, 2019

@RLittlesII RLittlesII changed the title Bug 1993 vs 2019 android wire up controls throws exception fix: VS2019 android wire up controls throws exception May 24, 2019

@glennawatson glennawatson merged commit ccf305b into reactiveui:master May 25, 2019

4 checks passed

ReactiveUI-CI Build #9.16.13+bf99a5faa3 succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.