Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ReactiveRecyclerViewAdapter having a incorrect out of bounds check #2055

Conversation

Projects
None yet
2 participants
@clintonrocksmith
Copy link
Contributor

commented May 29, 2019

fix: Added Equals to position and items.count check

Added Equals to ensure that the solution fails gracefully if there is…
… an issue with concurrency between the list and what the UI is trying to draw

@clintonrocksmith clintonrocksmith requested a review from reactiveui/android-team as a code owner May 29, 2019

@glennawatson glennawatson changed the title fix: Added Equals to ensure that the solution fails gracefully fix: ReactiveRecyclerViewAdapter having a incorrect out of bounds check May 30, 2019

@glennawatson glennawatson merged commit cb3e028 into reactiveui:master May 30, 2019

4 checks passed

ReactiveUI-CI Build #9.16.7+38198f4b8d succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.