Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Correct links to Installation docs #2060

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
3 participants
@worldbeater
Copy link
Member

commented May 31, 2019

What kind of change does this PR introduce?

Fix #2053

What is the current behavior?

Links to the Installation page are broken.

What is the new behavior?

Links to the Installation page are no longer broken.

What might this PR break?

Nothing.

@worldbeater worldbeater requested review from reactiveui/core-team as code owners May 31, 2019

@codecov

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #2060 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2060   +/-   ##
======================================
  Coverage    60.2%   60.2%           
======================================
  Files         116     116           
  Lines        4453    4453           
  Branches      639     639           
======================================
  Hits         2681    2681           
  Misses       1600    1600           
  Partials      172     172
Impacted Files Coverage Δ
...veUI/Platforms/windows-common/ViewModelViewHost.cs 8% <0%> (ø) ⬆️
...ctiveUI/Platforms/windows-common/RoutedViewHost.cs 0% <0%> (ø) ⬆️
...iveUI/Mixins/ReactiveNotifyPropertyChangedMixin.cs 91.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3e028...5113bdf. Read the comment docs.

@RLittlesII RLittlesII merged commit 790dc80 into master May 31, 2019

5 of 6 checks passed

codecov/patch 0% of diff hit (target 60.2%)
Details
ReactiveUI-CI Build #9.16.8+c01083cfc0 succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/project 60.2% remains the same compared to cb3e028
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the correct-installation-links branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.