Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added Uno support #2067

Merged
merged 35 commits into from Jun 26, 2019

Conversation

Projects
None yet
6 participants
@weitzhandler
Copy link
Contributor

commented Jun 12, 2019

This PR adds initial support for the Uno Platform.

@weitzhandler weitzhandler requested review from reactiveui/core-team as code owners Jun 12, 2019

glennawatson and others added some commits Jun 15, 2019

@weitzhandler weitzhandler requested review from reactiveui/uwp-team as code owners Jun 17, 2019

@weitzhandler weitzhandler changed the title Added Uno ReactivePage Added Uno support Jun 17, 2019

weitzhandler and others added some commits Jun 17, 2019

@weitzhandler

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

Looks like generic type arguments are not supported.

Opened suggestion.

Anyway the solution I'm thinking of, is having on each view code-behind a dummy class that inherits from ReactiveUserControl<TViewModel> and is used as the XAML subclass, for example:

<v:ReactiveMainPage
  xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
  xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
  xmlns:v="using:MyProject.Views"
  x:Class="MyProject.Views.MainPage"  
/>
namespace MyProject.Views
{
  public class ReactiveMainPage  : ReactiveUserControl<MainPageViewModel>
  { 
  }

  public sealed partial class MainPage : ReactiveMainPage
  {
  }
}

I'd be happy to hear about any other ideas of course.

@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

/// Note that UWP projects do not support the <c>TypeArguments</c> attribute. The XAML designer window in WPF projects also does not
that's the current proposal we have for users in our docs.

@weitzhandler

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

@jeromelaban can u take a look around here?

@jeromelaban
Copy link

left a comment

Looks good to me!

Show resolved Hide resolved src/ReactiveUI.Uno/ReactiveUI.Uno.csproj Outdated
Show resolved Hide resolved src/ReactiveUI.Uno/ReactiveUI.Uno.csproj

ghuntley and others added some commits Jun 18, 2019

@weitzhandler weitzhandler requested a review from reactiveui/devops-team as a code owner Jun 18, 2019

@weitzhandler

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

@glennawatson Perhaps revert this commit, I opened #2078 for that.

glennawatson and others added some commits Jun 18, 2019

@weitzhandler weitzhandler requested a review from reactiveui/learning-team as a code owner Jun 19, 2019

Show resolved Hide resolved README.md Outdated
@glennawatson

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

Leave it in, I'm going to check some stuff the blazer guys did which would affect that portion of the code.

glennawatson and others added some commits Jun 19, 2019

@glennawatson glennawatson changed the title Added Uno support feature: Added Uno support Jun 26, 2019

glennawatson added some commits Jun 26, 2019

@glennawatson glennawatson merged commit 121458e into reactiveui:master Jun 26, 2019

4 checks passed

ReactiveUI-CI Build #9.17.34+9e980f5bee succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
license/cla All CLA requirements met.
Details
@weitzhandler

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Thank you guys for the hard work, you're amazing!

arda-a added a commit to arda-a/ReactiveUI that referenced this pull request Jul 5, 2019

madmonkey added a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.