Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Use Pharmacist for platform code generation. #2072

Merged
merged 3 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

commented Jun 14, 2019

  • Use latest pharmacist for various platforms.
  • Remove event builder.

glennawatson added some commits Jun 10, 2019

feature: Swap the xam essentials to latest version.
Change processing over to using Pharmacist msbuild plugin

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Jun 14, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 14, 2019

Codecov Report

Merging #2072 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2072      +/-   ##
=========================================
- Coverage   60.22%   60.2%   -0.03%     
=========================================
  Files         116     116              
  Lines        4453    4453              
  Branches      639     639              
=========================================
- Hits         2682    2681       -1     
  Misses       1600    1600              
- Partials      171     172       +1
Impacted Files Coverage Δ
src/ReactiveUI/RxApp.cs 81.57% <0%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d1439...a9e6628. Read the comment docs.

@glennawatson glennawatson merged commit e044cd1 into master Jun 14, 2019

5 of 6 checks passed

codecov/project 60.2% (-0.03%) compared to a8d1439
Details
ReactiveUI-CI Build #9.16.13+b6ce9950dd succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing a8d1439...a9e6628
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-remove-eventbuilder-nuget branch Jun 14, 2019

madmonkey added a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.