Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Update the directory.build.props #2082

Merged
merged 4 commits into from Jun 23, 2019

Conversation

Projects
None yet
1 participant
@glennawatson
Copy link
Contributor

commented Jun 23, 2019

  • Updating the directory.build.props to have all the latest NuGet packages
  • Removed the base directory ones now, without the samples it's no longer as needed
  • To allow for easier debugging for android maintainers, using full debug type on that platform.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Jun 23, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 23, 2019

Codecov Report

Merging #2082 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
- Coverage   60.08%   60.05%   -0.03%     
==========================================
  Files         117      117              
  Lines        4464     4464              
  Branches      639      639              
==========================================
- Hits         2682     2681       -1     
  Misses       1611     1611              
- Partials      171      172       +1
Impacted Files Coverage Δ
src/ReactiveUI/RxApp.cs 81.57% <0%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ed350...a320aa0. Read the comment docs.

glennawatson added some commits Jun 23, 2019

@glennawatson glennawatson merged commit 03a2ac6 into master Jun 23, 2019

5 of 6 checks passed

codecov/project 60.05% (-0.03%) compared to 59da6e6
Details
ReactiveUI-CI Build #9.17.13+ece5b297f1 succeeded
Details
ReactiveUI-CI (Mac) Mac succeeded
Details
ReactiveUI-CI (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing 59da6e6...a320aa0
Details
license/cla All CLA requirements met.
Details

@delete-merged-branch delete-merged-branch bot deleted the glennawatson-update-pharmacist branch Jun 23, 2019

madmonkey added a commit to madmonkey/ReactiveUI that referenced this pull request Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.