Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Release 10.0 #2102

Merged
merged 35 commits into from Sep 4, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Jun 30, 2019

  • Rename IActivatable to IActivatableView

New Features:

  • .NET Core 3.0 support for WPF/Winforms.
  • PREVIEW: blazor support. This is likely to change.

Changes

  • Rename ISupportsActivation to IActivatableViewModel
  • Use the .net library version of INotifyPropertyChanging instead of implementing our own
  • Change most Tuple to ValueTuple's for performance reasons.
  • Now using Observable.FromEvent instead of FromEventPattern. Internal testing showed a 2x boost for doing this.

Removed

  • ReactiveList support is removed.
worldbeater and others added 10 commits Apr 11, 2019
Apply changes from 17558da missed due to git lfs master force push
@glennawatson glennawatson requested review from reactiveui/android-team as code owners Jun 30, 2019
@glennawatson

This comment has been minimized.

Copy link
Contributor Author

glennawatson commented Jun 30, 2019

hmm... I still wish I could make this a draft.

@glennawatson glennawatson changed the title housekeeping: Release 10.0.1 [WIP] housekeeping: Release 10.0.1 Jun 30, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 30, 2019

Codecov Report

Merging #2102 into master will increase coverage by 3.12%.
The diff coverage is 69.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2102      +/-   ##
==========================================
+ Coverage   58.82%   61.94%   +3.12%     
==========================================
  Files         117      107      -10     
  Lines        4760     4068     -692     
  Branches      740      575     -165     
==========================================
- Hits         2800     2520     -280     
+ Misses       1727     1367     -360     
+ Partials      233      181      -52
Impacted Files Coverage Δ
...rc/ReactiveUI/Activation/CanActivateViewFetcher.cs 33.33% <ø> (ø) ⬆️
...ReactiveUI/Platforms/net4/PlatformRegistrations.cs 66.66% <ø> (ø)
...orms/windows-common/AutoDataTemplateBindingHook.cs 77.27% <ø> (ø) ⬆️
...UI/Interfaces/ReactivePropertyChangingEventArgs.cs 100% <ø> (ø) ⬆️
...ctiveUI/Bindings/Property/PropertyBindingMixins.cs 87.5% <ø> (ø) ⬆️
...activeUI.Blend/Platforms/net4/ObservableTrigger.cs 0% <ø> (ø)
src/ReactiveUI.Wpf/AutoSuspendHelper.cs 0% <0%> (ø) ⬆️
src/ReactiveUI/Expression/Reflection.cs 60.27% <0%> (-1.7%) ⬇️
...ctiveUI/Platforms/windows-common/RoutedViewHost.cs 0% <0%> (ø) ⬆️
src/ReactiveUI/VariadicTemplates.cs 36.65% <0%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5359fd8...b0fd826. Read the comment docs.

glennawatson added 7 commits Jul 2, 2019
…veUI into preview/10.0.1
glennawatson added 10 commits Aug 26, 2019
Rename IActivatable to IActivatableView

Rename ISupportsActivation to IActivatableViewModel

Update System.Reactive

Fix mac build
@glennawatson glennawatson changed the title [WIP] housekeeping: Release 10.0.1 housekeeping: Release 10.0 Sep 3, 2019
@glennawatson glennawatson merged commit f396c32 into master Sep 4, 2019
4 checks passed
4 checks passed
ReactiveUI-CI Build #10.0.25+5000cfc7e7 succeeded
Details
codecov/patch 69.32% of diff hit (target 58.82%)
Details
codecov/project 61.94% (+3.12%) compared to 5359fd8
Details
license/cla All CLA requirements met.
Details
@glennawatson glennawatson deleted the preview/10.0.1 branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.