Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android DesignTimeBuild issue with MsBuild.Sdk.Extras #2137

Merged
merged 4 commits into from Aug 17, 2019

Conversation

@RLittlesII
Copy link
Contributor

RLittlesII commented Aug 17, 2019

What kind of change does this PR introduce?
Working around an Android build issue with MsBuild.Sdk.Extras

What is the current behavior?
ReactiveUI doesn't build.

What is the new behavior?
ReactiveUI builds.

What might this PR break?
Nothing that isn't already broken.

@RLittlesII RLittlesII requested a review from reactiveui/core-team as a code owner Aug 17, 2019
RLittlesII added 3 commits Aug 17, 2019
@RLittlesII RLittlesII requested review from reactiveui/android-team as code owners Aug 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #2137 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
- Coverage   58.84%   58.82%   -0.03%     
==========================================
  Files         117      117              
  Lines        4760     4760              
  Branches      740      740              
==========================================
- Hits         2801     2800       -1     
  Misses       1727     1727              
- Partials      232      233       +1
Impacted Files Coverage Δ
src/ReactiveUI/RxApp.cs 81.57% <0%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e9eda...2c798e7. Read the comment docs.

@RLittlesII RLittlesII merged commit dbc33b8 into master Aug 17, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/project 58.82% (-0.03%) compared to 33e9eda
Details
ReactiveUI-CI Build #9.20.6+521ddd4358 succeeded
Details
codecov/patch Coverage not affected when comparing 33e9eda...2c798e7
Details
license/cla All CLA requirements met.
Details
@RLittlesII RLittlesII deleted the feature/build branch Aug 17, 2019
@lock lock bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.