Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove exception in .netstandard 2.0 code #2163

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Sep 9, 2019

WASM projects will run under .net standard so the exception will likely cause issues in the future.

This removes the exception in the platform registrations.

This fixes #2162

…er of .net standard projects
@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Sep 9, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #2163 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2163      +/-   ##
==========================================
+ Coverage   61.89%   61.94%   +0.04%     
==========================================
  Files         107      107              
  Lines        4068     4068              
  Branches      575      575              
==========================================
+ Hits         2518     2520       +2     
+ Misses       1370     1367       -3     
- Partials      180      181       +1
Impacted Files Coverage Δ
src/ReactiveUI.Winforms/RoutedViewHost.cs 90.27% <0%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5c66e...08503a7. Read the comment docs.

@glennawatson glennawatson merged commit a342f88 into master Sep 9, 2019
4 checks passed
4 checks passed
ReactiveUI-CI Build #10.1.7+895822ebd5 succeeded
Details
codecov/patch Coverage not affected when comparing 5d5c66e...08503a7
Details
codecov/project 61.94% (+0.04%) compared to 5d5c66e
Details
license/cla All CLA requirements met.
@glennawatson glennawatson deleted the glennawatson-fix-blazor-netstandard branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.