Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Move to Portable Libraries #217
In ReactiveUI 5.0, support is being dropped for WP7.x and .NET 4.0, meaning that it makes more sense now to move to Portable Libraries.
Reorganize All The Things
Now that certain types have moved around in .NET 4.5 (most notably,
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Validation classes such as ValidationAttribute and ValidationContext are not available in Portable Class Libraries.
this.ValidationFor(x => x.SomeProperty, value => value != null, "error message");
What do you think?
Validation is delicate in any case. The WPF
Maybe we could try an extensible validation framework? Portable and extensible side in the portable library, plug in from ReactiveUI.Xaml / ReactiveUI.Cocoa / ReactiveUI.Android
Also, I do think that validation should be with the binding, maybe an extension of the binding syntax. After all, it does modify what the binding needs to do significantly (we don't want to set the value of the binding if it fails validation), though I still quite like your syntax. We would have to intercept the property setting in this case I think.
And I just noticed that I said something inexact
This is not true in the current
Now this is the kind of thinking I can get behind :)
I'll have to think about how to do this elegantly - the binder is already super complicated as-is with type conversion and binding hooks.