Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in non-UI .netcoreapp3.0 applications a compile error is produced. #2171

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Sep 19, 2019

The preview versions of Reactive Extensions contain UseWPF and UseWinforms, which will force the client library to attempt to find those. This does not work on non-windows builds of .net core app 3.0 applications.

The WPF/WinForms versions contain the preview System.Reactive with these changes which will still allow those .net core app users to use WPF/WinForms on .net core app 3.0

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Sep 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #2171 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2171   +/-   ##
=======================================
  Coverage   61.94%   61.94%           
=======================================
  Files         107      107           
  Lines        4068     4068           
  Branches      575      575           
=======================================
  Hits         2520     2520           
  Misses       1367     1367           
  Partials      181      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355dcb0...94731a9. Read the comment docs.

@glennawatson glennawatson merged commit a20758e into master Sep 19, 2019
4 checks passed
4 checks passed
ReactiveUI-CI Build #10.2.3+67a8fe4fdb succeeded
Details
codecov/patch Coverage not affected when comparing 355dcb0...94731a9
Details
codecov/project 61.94% remains the same compared to 355dcb0
Details
license/cla All CLA requirements met.
@glennawatson glennawatson deleted the glennawatson-patch-1 branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.