Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Update to splat 9 #2173

Merged
merged 4 commits into from Sep 20, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Sep 20, 2019

Remove the indicator for range indicators from RxApp due to not needed since the removal of ReactiveList
Removed redundant ExtrasEnableWpfProjectSetup for projects.

Remove the indicator for range indicators from RxApp due to not needed since the removal of ReactiveList
@glennawatson glennawatson requested review from reactiveui/android-team as code owners Sep 20, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #2173 into master will decrease coverage by 0.66%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2173      +/-   ##
==========================================
- Coverage   61.94%   61.28%   -0.67%     
==========================================
  Files         107      107              
  Lines        4068     4063       -5     
  Branches      575      575              
==========================================
- Hits         2520     2490      -30     
- Misses       1367     1395      +28     
+ Partials      181      178       -3
Impacted Files Coverage Δ
src/ReactiveUI/RxApp.cs 69.11% <ø> (-12.47%) ⬇️
...ReactiveUI/Platforms/net4/PlatformRegistrations.cs 70% <ø> (+3.33%) ⬆️
src/ReactiveUI.Wpf/Registrations.cs 80% <100%> (+1.42%) ⬆️
src/ReactiveUI.Winforms/Registrations.cs 64.28% <100%> (+2.74%) ⬆️
src/ReactiveUI/Suspension/SuspensionHost.cs 0% <0%> (-50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 721c4a2...b3d9b2b. Read the comment docs.

@glennawatson glennawatson merged commit eb2dff2 into master Sep 20, 2019
4 checks passed
4 checks passed
ReactiveUI-CI Build #10.2.8+1e2965362f succeeded
Details
codecov/patch 100% of diff hit (target 61.94%)
Details
codecov/project Absolute coverage decreased by -0.66% but relative coverage increased by +38.05% compared to 721c4a2
Details
license/cla All CLA requirements met.
Details
@glennawatson glennawatson deleted the glennawatson-add-splat-9 branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.