Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the WPF designer by removing abstract #2180

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Sep 26, 2019

Chris Pullman on Slack noticed that if classes aren't marked as abstract, the designer will function for WPF, where previously they wouldn't.

Removing the abstract on these classes to allow for the designer to function.

@glennawatson glennawatson requested review from reactiveui/uwp-team as code owners Sep 26, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #2180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2180   +/-   ##
=======================================
  Coverage   61.28%   61.28%           
=======================================
  Files         107      107           
  Lines        4063     4063           
  Branches      575      575           
=======================================
  Hits         2490     2490           
  Misses       1395     1395           
  Partials      178      178
Impacted Files Coverage Δ
...UI/Platforms/windows-common/ReactiveUserControl.cs 0% <ø> (ø) ⬆️
...eactiveUI/Platforms/windows-common/ReactivePage.cs 0% <ø> (ø) ⬆️
src/ReactiveUI.Wpf/ReactiveWindow.cs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a19504...5eab497. Read the comment docs.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Sep 26, 2019
@RLittlesII RLittlesII merged commit e77e1e5 into master Sep 26, 2019
4 checks passed
4 checks passed
ReactiveUI-CI Build #10.3.6+0b6ea5f332 succeeded
Details
codecov/patch Coverage not affected when comparing 753e511...5eab497
Details
codecov/project 61.28% remains the same compared to 753e511
Details
license/cla All CLA requirements met.
Details
@RLittlesII RLittlesII deleted the glennawatson-make-abstract branch Sep 26, 2019
@ChrisPulman

This comment has been minimized.

Copy link

ChrisPulman commented Sep 26, 2019

Thanks for the mention @glennawatson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.