Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Msbuild nuget package description validation #2189

Merged
merged 6 commits into from Oct 3, 2019

Conversation

@dpvreony
Copy link
Contributor

dpvreony commented Oct 2, 2019

What kind of change does this PR introduce?

Housekeeping for build process to enforce #2182 and ensure nuget package descriptions are set AND not the default.

What is the current behavior?
#2182 all packages have same description

What is the new behavior?
msbuild task in targets file to validate pre-compile stage.

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

merge after #2182 as it will break the build prior to that being completed.

dpvreony added 3 commits Oct 1, 2019
@dpvreony dpvreony requested a review from reactiveui/core-team as a code owner Oct 2, 2019
@dpvreony dpvreony self-assigned this Oct 2, 2019
src/Directory.build.props Outdated Show resolved Hide resolved
dpvreony and others added 2 commits Oct 2, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #2189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2189   +/-   ##
=======================================
  Coverage   61.68%   61.68%           
=======================================
  Files         107      107           
  Lines        4069     4069           
  Branches      579      579           
=======================================
  Hits         2510     2510           
  Misses       1379     1379           
  Partials      180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0fa9b...f79661c. Read the comment docs.

@glennawatson glennawatson changed the title WIP Housekeeping: Msbuild nuget package description validation Housekeeping: Msbuild nuget package description validation Oct 3, 2019
@glennawatson glennawatson merged commit f5f8d9a into master Oct 3, 2019
4 checks passed
4 checks passed
ReactiveUI-CI Build #10.3.13+9a473a9f67 succeeded
Details
codecov/patch Coverage not affected when comparing 1d0fa9b...f79661c
Details
codecov/project 61.68% remains the same compared to 1d0fa9b
Details
license/cla All CLA requirements met.
Details
@glennawatson glennawatson deleted the msbuildnugetpropertyvalidation branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.