Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: give packages unique descriptions and tags #2190

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@rgomez90
Copy link
Contributor

rgomez90 commented Oct 2, 2019

Fixes #2182

What kind of change does this PR introduce?

Updates descriptions of NuGet packages to be specific for each package

What is the current behavior?

Same description for all packages

What is the new behavior?

Each package has its own specific description

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@rgomez90 rgomez90 requested review from reactiveui/android-team as code owners Oct 2, 2019
@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Oct 2, 2019

Apart from that one csproj everything looks good

@glennawatson glennawatson changed the title Update Package descriptions Feature: give packages unique descriptions and tags Oct 2, 2019
Update Testing & Base project package descriptions
@rgomez90 rgomez90 force-pushed the rgomez90:fix2182 branch from 1f39684 to 573edc8 Oct 2, 2019
@glennawatson glennawatson merged commit 1d0fa9b into reactiveui:master Oct 2, 2019
2 checks passed
2 checks passed
ReactiveUI-CI Build #10.3.11+e33ce30cd6 succeeded
Details
license/cla All CLA requirements met.
Details
@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Oct 3, 2019

Awesome. Another bug down. If you want any particular tasks in the future let me know and I'll what I can find.

@rgomez90 rgomez90 deleted the rgomez90:fix2182 branch Oct 3, 2019
@rgomez90

This comment has been minimized.

Copy link
Contributor Author

rgomez90 commented Oct 3, 2019

@glennawatson I've notice I forgot the fixes #2182

Think issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.