Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump Microsoft.CodeAnalysis.FxCopAnalyzers from 2.6.3 to 2.9.6 #2193

Conversation

@dependabot-preview
Copy link
Contributor

dependabot-preview bot commented Oct 4, 2019

Bumps Microsoft.CodeAnalysis.FxCopAnalyzers from 2.6.3 to 2.9.6.

Release notes

Sourced from Microsoft.CodeAnalysis.FxCopAnalyzers's releases.

v2.9.6

Release build of Roslyn-analyzers based on Microsoft.CodeAnalysis 2.9.0 NuGet packages. Works with VS 2017.9 or later.

Contains following important bug fix on top of v2.9.5 release:

v2.9.5

Release build of Roslyn-analyzers based on Microsoft.CodeAnalysis 2.9.0 NuGet packages. Works with VS 2017.9 or later.

Contains following important changes on top of v2.9.4 release

Bug Fixes

  • Critical Performance: Fixed memory leak in flow analysis results cache which leads to OOM exceptions and crashes on large solution. This is applicable for all rules
  • Critical Reliability: Hardened all the analyzers and fixers from crashes due to Single or SingleOrDefault invocations.
  • CA1065: Fixed false positives caused by breaking changes in the IOperation tree shape for throw operations.
  • CA1067: Fixed false positives.
  • CA1708: Fix high memory allocations in the rule implementation
  • CA1721: Fixed false positives.
  • CA2000: Fixed false positives
  • CA2234: Fixed false positives
  • CA2327: Do not use insecure JsonSerializerSettings -- Fixed InvalidCastException
  • CA3147: Mark verb handlers with ValidateAntiForgeryToken -- Now handles Task-based ASP.NET MVC controller action methods
  • CA3075: Insecure DTD processing in XML -- Fixed NullReferenceException.
  • CA3076: Insecure XSLT script processing -- Fixed ArgumentOutOfRangeException.
  • CA5390: Do Not Hard Code Encryption Key -- Treats Encoding.GetBytes() as a potentially hardcoded key. Also considers newer .NET Core 3.0 AesGcm and AesCcm APIs.

Additional analyzers/fixers:

Added

  • Performance
    • CA1828: Do not use CountAsync() or LongCountAsync() when AnyAsync() can be used -- Enabled by default
    • CA1829: Use Length/Count property instead of Count() when available -- Enabled by default
  • Security
    • CA2329: Do not deserialize with JsonSerializer using an insecure configuration
    • CA2330: Ensure that JsonSerializer has a secure configuration when deserializing
    • CA5391: Use antiforgery tokens in ASP.NET Core MVC controllers -- Enabled by default
    • CA5392: Use DefaultDllImportSearchPaths attribute for P/Invokes
    • CA5393: Do not use unsafe DllImportSearchPath value
    • CA5394: Do not use insecure randomness
    • CA5395: Miss HttpVerb attribute for action methods
    • CA5396: Set HttpOnly to true for HttpCookie
    • CA5397: Do not use deprecated SslProtocols values -- Enabled by default
    • CA5398: Avoid hardcoded SslProtocols values
    • CA5399: Definitely disable HttpClient certificate revocation list check
    • CA5400: Ensure HttpClient certificate revocation list check is not disabled
  • Usage
    • CA2246: Assigning to a symbol and its member (field/property) in the same statement is not recommended. It is not clear if the member access was intended to use symbol's old value prior to the assignment or new value from the assignment in this statement. For clarity, consider splitting the assignments into separate statements -- Enabled by default
    • CA2200: Code fix added

Changed

  • Security
... (truncated)
Commits
  • b377a16 Merge pull request #2899 from mavasani/EnableBuildsOnPRs
  • aeeb21c Trigger builds on PR
  • ce47356 Merge pull request #2887 from mavasani/MoveToNewVersion
  • fe919bf Merge pull request #2894 from mavasani/Issue2889
  • 8047d1f Fix NRE in AssigningSymbolAndItsMemberInSameStatement analyzer
  • 8faf89c Post release activities for 2.9.5 package release
  • 6c05175 Merge pull request #2882 from mavasani/EditorConfigFiles
  • 4bc7bc6 Merge pull request #2883 from mavasani/FixNRE
  • 789704f Merge pull request #2764 from dotnet/feature/catch_isymbol_equals_without_com...
  • 8570e00 Fix NRE in recently added AssigningSymbolAndItsMemberInSameStatement analyzer
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)
@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Oct 12, 2019

@dependabot rebase

@dependabot-preview

This comment has been minimized.

Copy link
Contributor Author

dependabot-preview bot commented Oct 12, 2019

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Oct 12, 2019

@dependabot recreate

Bumps [Microsoft.CodeAnalysis.FxCopAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 2.6.3 to 2.9.6.
- [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
- [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md)
- [Commits](dotnet/roslyn-analyzers@v2.6.3...v2.9.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-2.9.6 branch from db2b96c to 7e5a09c Oct 12, 2019
@glennawatson glennawatson merged commit a82f7a6 into master Oct 12, 2019
1 of 2 checks passed
1 of 2 checks passed
ReactiveUI-CI Build #10.4.6+a6f363b558 failed
Details
license/cla All CLA requirements met.
@glennawatson glennawatson deleted the dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-2.9.6 branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.