Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TypeLoadException in .net core app 3.0 #2195

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@anaisbetts
Copy link
Member

anaisbetts commented Oct 4, 2019

Fixes #2194

What might this PR break?

Should be fine, anyone using .NET Framework where this works will have MainThreadScheduler paved by RxApp itself later anyways

@anaisbetts anaisbetts requested a review from reactiveui/wpf-team as a code owner Oct 4, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #2195 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2195      +/-   ##
==========================================
- Coverage   61.68%   61.61%   -0.08%     
==========================================
  Files         107      107              
  Lines        4069     4072       +3     
  Branches      579      580       +1     
==========================================
- Hits         2510     2509       -1     
- Misses       1379     1382       +3     
- Partials      180      181       +1
Impacted Files Coverage Δ
src/ReactiveUI.Wpf/Registrations.cs 61.11% <0%> (-18.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f8d9a...12540b5. Read the comment docs.

@anaisbetts anaisbetts changed the title Only set MainThreadScheduler if we are not in a unit-test runner Fix: Only set MainThreadScheduler if we are not in a unit-test runner Oct 4, 2019
@glennawatson glennawatson changed the title Fix: Only set MainThreadScheduler if we are not in a unit-test runner Fix: TypeLoadException in .net core app 3.0 Oct 4, 2019
@glennawatson glennawatson merged commit 382ac40 into master Oct 4, 2019
2 of 4 checks passed
2 of 4 checks passed
codecov/patch 0% of diff hit (target 61.68%)
Details
codecov/project 61.61% (-0.08%) compared to f5f8d9a
Details
ReactiveUI-CI Build #10.3.12+d2715a4e2e succeeded
Details
license/cla All CLA requirements met.
@glennawatson glennawatson deleted the dont-set-scheduler-in-test-runner branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.