Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add Android unit tests #2201

Merged
merged 6 commits into from Oct 12, 2019

Conversation

@duracellko
Copy link
Contributor

duracellko commented Oct 9, 2019

Implements #1939 Android: add unit tests

  • Added ReactiveUI.Android.Tests project that runs unit tests ReactiveUI.Tests in Android.
  • LocalizableAttribute was enabled for Android target framework, because it is used in some tests.
  • PocoObservableForPropertyTests
    • TestLogger is unregistered after test run. In Android AppDomain is not unloaded after test run, so TestLogger keeps registered.
    • NotificationPocoErrorOnBind test is executed twice to verify that message is logged first time only.
  • DefaultViewLocatorTests.NoErrorIsRaisedIfATypeCannotBeFound adds assembly name in "DoesNotExist" type name, because it was failing on Mono.

Other information

  • Resource.designer.cs is excluded from Git repository. It is automatically generated by Visual Studio.
    • Maybe Cake build should create empty Resource.designer.cs file. MSBuild requires empty file to generate Android resources. It fails, when the file is missing.
  • Tests ApiApprovalTests are failing on Android. I don't think PublicApiGenerator is supported on Android.

Open questions

  1. Does ReactiveUI.Android.Tests project need to be added to Cake build? I don't see it in ReactiveUI.Splat repository.
@duracellko duracellko requested a review from reactiveui/core-team as a code owner Oct 9, 2019
@RLittlesII RLittlesII changed the title Android: add unit tests feature: add Android unit tests Oct 9, 2019
@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Oct 9, 2019

I have been planning on replacing the API approval so feel free to leave those out.

Thanks for doing this.

glennawatson and others added 3 commits Oct 10, 2019
@glennawatson glennawatson merged commit 8fb45dc into reactiveui:master Oct 12, 2019
2 checks passed
2 checks passed
ReactiveUI-CI Build #10.4.6+ea8ae64982 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.