Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sometimes the core dispatcher can't be fetched in constructor #2255

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@jasonwurzel
Copy link
Contributor

jasonwurzel commented Nov 21, 2019

this fix is related to #2154 , some more testing showed that the former bugfix also has to be in place in ScheduleOnDispatcherNow

What kind of change does this PR introduce?

fix related to #2154

What is the current behavior?

When accessing the RxApp.MainThreadScheduler too early (i.e. no MainWindow yet), the CoreDispatcher can't be fetched in SingleWindowDispatcherScheduler's ctor. Thus, ScheduleOnDispatcherNow has to contain the original fix as well (check if _dispatcher is still null and if so, try again fetching the Dispatcher.)

What is the new behavior?

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

this fix is related to #2154 , some more testing showed that the former bugfix also has to be in place in ScheduleOnDispatcherNow
@jasonwurzel jasonwurzel requested a review from reactiveui/core-team as a code owner Nov 21, 2019
@glennawatson glennawatson merged commit d53a86b into reactiveui:master Nov 21, 2019
2 checks passed
2 checks passed
ReactiveUI-CI #10.5.32+5ae13f475f succeeded
Details
license/cla All CLA requirements met.
Details
@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Nov 21, 2019

Thanks @jasonwurzel I will put out another release tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.