Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues with binding to library #2272

Merged
merged 1 commit into from Dec 5, 2019
Merged

fix: issues with binding to library #2272

merged 1 commit into from Dec 5, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Dec 5, 2019

What kind of change does this PR introduce?

fixes #2264

What is the current behavior?

That it fails to load assemblies on .net native. It attempts to check to see if the assemblies exist.

What is the new behavior?

Will have the old exception back for unknown assemblies. This will be fixed with init() changes later.

What might this PR break?

Goes back to old functionality so shouldn't.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Dec 5, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #2272 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
- Coverage   55.81%   55.77%   -0.04%     
==========================================
  Files         114      114              
  Lines        4490     4486       -4     
  Branches      688      688              
==========================================
- Hits         2506     2502       -4     
  Misses       1803     1803              
  Partials      181      181
Impacted Files Coverage Δ
src/ReactiveUI/Mixins/DependencyResolverMixins.cs 90.47% <100%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25522a7...57289fe. Read the comment docs.

@velocitysystems

This comment has been minimized.

Copy link

velocitysystems commented Dec 5, 2019

Thanks @glennawatson...Phew, good to have this in. We certainly would appreciate this fix in an updated NuGet package as soon as it can be released, as we have been chasing this .NET native bug for the last day or so until tracking it down to this thread.

@RLittlesII RLittlesII merged commit f79c82b into master Dec 5, 2019
4 checks passed
4 checks passed
ReactiveUI-CI #10.5.36+68fbb8a490 succeeded
Details
codecov/patch 100% of diff hit (target 55.81%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +44.18% compared to 25522a7
Details
license/cla All CLA requirements met.
@RLittlesII RLittlesII deleted the fix-loading branch Dec 5, 2019
@velocitysystems

This comment has been minimized.

Copy link

velocitysystems commented Dec 5, 2019

Thanks @RLittlesII for completing the merge. Do you know approximately when will this be available as an updated NuGet?

@glennawatson

This comment has been minimized.

Copy link
Contributor Author

glennawatson commented Dec 5, 2019

Will be out in the next couple hours.

@glennawatson

This comment has been minimized.

Copy link
Contributor Author

glennawatson commented Dec 5, 2019

Have a look at https://www.nuget.org/packages/reactiveui/10.5.43

A MVVM framework that integrates with the Reactive Extensions for .NET to create elegant, testable User Interfaces that run on any mobile or desktop platform. This is the base package with the base platform implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.