Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reflection.ThrowIfMethodsNotOverloaded #2284

Merged
merged 1 commit into from Dec 17, 2019

Conversation

@TheKeyblader
Copy link
Contributor

TheKeyblader commented Dec 17, 2019

What kind of change does this PR introduce?

Bug Fix #2282

What is the current behavior?

Using AutoSuspendHelper on UWP,Mac,IOS do crash the app on startup

What is the new behavior?

AutoSuspendHelper work correctly on UWP (can't test on Mac, IOS)

What might this PR break?

Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
dont know why build.cmd crash with this errors

Setting up tools...
Error: One or more errors occurred. (Object reference not set to an instance of an object.)
        Object reference not set to an instance of an object.
@TheKeyblader TheKeyblader requested a review from reactiveui/core-team as a code owner Dec 17, 2019
@glennawatson glennawatson merged commit 75e1b70 into reactiveui:master Dec 17, 2019
1 check passed
1 check passed
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.