Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warnings about package downgrade #2293

Merged
merged 1 commit into from Dec 30, 2019
Merged

Conversation

@weitzhandler
Copy link
Contributor

weitzhandler commented Dec 29, 2019

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
When targeting ReactiveUI.Uno, I'm getting warnings such as this one:

image

What is the new behavior?
Let's make it equal to the main ReactiveUI project, that depends on Splat.Drawing version 9.*, rather than a specific version.
This causes warnings.

When targeting `ReactiveUI.Uno`, I'm getting warnings such as this one:

![image](https://user-images.githubusercontent.com/2716316/71563188-17bcd880-2a94-11ea-8e4d-48f5d9b547aa.png)

Let's make it equal to the main ReactiveUI project, that depends on `Splat.Drawing` version `9.*`, rather than a specific version.
This causes warnings.
@weitzhandler weitzhandler requested a review from reactiveui/core-team as a code owner Dec 29, 2019
@weitzhandler weitzhandler changed the title Avoid warnings about package downgrade fix: Avoid warnings about package downgrade Dec 29, 2019
@weitzhandler weitzhandler changed the title fix: Avoid warnings about package downgrade fix: warnings about package downgrade Dec 29, 2019
@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Dec 30, 2019

This wouldn't solve your issue. Eg at the time the NuGet gets built the version gets locked in.

@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Dec 30, 2019

Also we are using Dependabot

@glennawatson glennawatson reopened this Dec 30, 2019
@glennawatson glennawatson merged commit 308b082 into reactiveui:master Dec 30, 2019
2 checks passed
2 checks passed
ReactiveUI-CI Build #11.0.11+1aff2e7c56 succeeded
Details
license/cla All CLA requirements met.
@weitzhandler weitzhandler deleted the weitzhandler:uno branch Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.