Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Enable WASM on Blazor #2295

Merged
merged 10 commits into from Jan 1, 2020
Merged

Conversation

@richbryant
Copy link
Contributor

richbryant commented Dec 30, 2019

What kind of change does this PR introduce?

Bug fix. Changes to Registrations class to enable ReactiveUI.Blazor to determine operating platform effectively, Scheduler initialization

What is the current behavior?

mono-wasm throws errors when initializing ReactiveCommand

What is the new behavior?

No errors, commands work.

What might this PR break?

Potential to break ReactiveUI.Blazor on Server IF scheduling changes. Potential to become obsolete once mono-wasm utilizes wasm threading.

Other information:

Requires latest PR raised against System.Reactive.Wasm

Richard Bryant added 2 commits Dec 23, 2019
@richbryant richbryant requested a review from reactiveui/core-team as a code owner Dec 30, 2019
<PackageReference Include="Microsoft.AspNetCore.Components" Version="3.1.0" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\..\..\Users\richardb\source\repos\richbryant\Reactive.Wasm\src\System.Reactive.Wasm\System.Reactive.Wasm.csproj" />

This comment has been minimized.

Copy link
@glennawatson

glennawatson Dec 30, 2019

Contributor

This is likely to be an issue. I would recommend just doing a NuGet reference.

This comment has been minimized.

Copy link
@richbryant

richbryant Dec 30, 2019

Author Contributor

on it

This comment has been minimized.

Copy link
@glennawatson

glennawatson Dec 30, 2019

Contributor

You can use NuGet wildcard versioning. Eg 1.* and then we can set the version of system.reactive.wasm to match.

This comment has been minimized.

Copy link
@richbryant

richbryant Dec 30, 2019

Author Contributor

Nuts. Okay. Will commit again.

This comment has been minimized.

Copy link
@richbryant

richbryant Dec 30, 2019

Author Contributor

Build failed with wildcard versioning so I had to revert that. Please feel free to amend this if you can make it build :(

This comment has been minimized.

Copy link
@glennawatson

glennawatson Jan 1, 2020

Contributor

You should be able to wildcard now that I released 1.2.1

This comment has been minimized.

Copy link
@richbryant

richbryant Jan 1, 2020

Author Contributor

it's 01:13Hrs here. I'll do that tomorrow :) Probably mistake-prone right now.

Richard Bryant and others added 4 commits Dec 30, 2019
Richard Bryant
@richbryant richbryant requested a review from glennawatson Dec 31, 2019
glennawatson added 2 commits Jan 1, 2020
@glennawatson glennawatson changed the title Update to enable ReactiveUI on WASM feature: Enable WASM on Blazor Jan 1, 2020
@glennawatson glennawatson merged commit 5d4d4f0 into reactiveui:master Jan 1, 2020
2 checks passed
2 checks passed
ReactiveUI-CI Build #11.0.17+e427bcf425 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.