Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add ReactiveUI.Drawing #2353

Merged
merged 5 commits into from Feb 25, 2020
Merged

feature: Add ReactiveUI.Drawing #2353

merged 5 commits into from Feb 25, 2020

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Feb 25, 2020

What kind of change does this PR introduce?

feature

What's changed?

This adds ReactiveUI.Drawing.

This resolves #2342

Splat.Drawing isn't required by all users and can cause a lot of startup processing for Android users.

Now only users who want to opt into the functionality provided by Splat.Drawing need to add the new assembly.

This also updates the tests to use netcoreapp3.1

What might this PR break?

Users will have to use ReactiveUI.Drawing if they are using the Splat.Drawing functionality.

glennawatson and others added 2 commits Feb 25, 2020
@glennawatson glennawatson requested review from reactiveui/android-team as code owners Feb 25, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #2353 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2353      +/-   ##
==========================================
- Coverage   54.73%   54.66%   -0.07%     
==========================================
  Files         113      114       +1     
  Lines        4334     4341       +7     
  Branches      660      663       +3     
==========================================
+ Hits         2372     2373       +1     
- Misses       1797     1801       +4     
- Partials      165      167       +2     
Impacted Files Coverage Δ
src/ReactiveUI.Drawing/Registrations.cs 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd1830...ae897ed. Read the comment docs.

@@ -71,7 +71,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="xunit.runner.devices">
<Version>2.*</Version>
<Version>2.5.25</Version>

This comment has been minimized.

Copy link
@RLittlesII

RLittlesII Feb 25, 2020

Contributor

Specific version?

@@ -22,7 +23,7 @@
</ItemGroup>

<Choose>
<When Condition=" $(TargetFramework.StartsWith('netcoreapp3.0')) ">
<When Condition=" $(TargetFramework.StartsWith('netcoreapp3.0')) AND '$(OS)' == 'Windows_NT'">

This comment has been minimized.

Copy link
@RLittlesII

RLittlesII Feb 25, 2020

Contributor

Should this check for netcoreapp3.x?

@glennawatson glennawatson merged commit b7df987 into master Feb 25, 2020
2 of 4 checks passed
2 of 4 checks passed
codecov/patch 50.00% of diff hit (target 54.73%)
Details
codecov/project 54.66% (+-0.07%) compared to ecd1830
Details
ReactiveUI-CI Build #11.2.5+b3ae62ca26 succeeded
Details
license/cla All CLA requirements met.
Details
@glennawatson glennawatson deleted the glennawatson-update-version branch Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.