Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Added Android Resource Designer to .gitignore #2357

Merged
merged 1 commit into from Feb 27, 2020

Conversation

@RLittlesII
Copy link
Contributor

RLittlesII commented Feb 27, 2020

What kind of change does this PR introduce?

Still seeing instances of the Android Resource Designer file.

What is the current behavior?

Adding better removal of Resource Designer.

What is the new behavior?

No further Android Resource Designer files should make it in.

What might this PR break?

Android tests.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@RLittlesII RLittlesII requested a review from reactiveui/core-team as a code owner Feb 27, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #2357 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2357   +/-   ##
=======================================
  Coverage   54.66%   54.66%           
=======================================
  Files         114      114           
  Lines        4341     4341           
  Branches      663      663           
=======================================
  Hits         2373     2373           
  Misses       1801     1801           
  Partials      167      167           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3432418...2d638ab. Read the comment docs.

@worldbeater worldbeater merged commit e2c538c into master Feb 27, 2020
4 checks passed
4 checks passed
ReactiveUI-CI Build #11.2.4+c39fc7e390 succeeded
Details
codecov/patch Coverage not affected when comparing 3432418...2d638ab
Details
codecov/project 54.66% (+0.00%) compared to 3432418
Details
license/cla All CLA requirements met.
Details
@worldbeater worldbeater deleted the feature/resource branch Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.