Skip to content

Conversation

@ChrisPulman
Copy link
Member

Refactored RoutedViewHost and ViewModelViewHost to allow DefaultContent to be shown

fixes #2815

What kind of change does this PR introduce?

fix

What is the current behaviour?

DefaultContent is not displayed for RoutedViewHost and ViewModelViewHost when loaded with null ViewModel

What is the new behaviour?

DefaultContent is displayed for RoutedViewHost and ViewModelViewHost when loaded with null ViewModel

What might this PR break?

Content will have a value when previously may not have depending upon the version of ReactiveUI i.e. >9.8.9

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #2816 (9c5df4e) into main (ec9535e) will increase coverage by 2.48%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2816      +/-   ##
==========================================
+ Coverage   65.77%   68.26%   +2.48%     
==========================================
  Files         137      137              
  Lines        4810     4787      -23     
==========================================
+ Hits         3164     3268     +104     
+ Misses       1646     1519     -127     
Impacted Files Coverage Δ
...veUI/Platforms/windows-common/ViewModelViewHost.cs 83.33% <78.94%> (+74.76%) ⬆️
...ctiveUI/Platforms/windows-common/RoutedViewHost.cs 86.44% <86.95%> (+86.44%) ⬆️
src/ReactiveUI.Wpf/TransitioningContentControl.cs 12.72% <0.00%> (+3.63%) ⬆️
...UI/Platforms/windows-common/ReactiveUserControl.cs 72.72% <0.00%> (+72.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec9535e...9c5df4e. Read the comment docs.

@glennawatson glennawatson merged commit f97fb4b into main Jul 9, 2021
@glennawatson glennawatson deleted the fix_For#2815 branch July 9, 2021 05:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] WPF - ViewModelViewHost and RoutedViewHost not displaying DefaultContent

3 participants