From 5de4d9db99b12e9341bf00693e85b04381ba0688 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Aug 2021 00:35:30 +0000 Subject: [PATCH 1/4] build(deps): bump Microsoft.NET.Test.Sdk in /integrationtests Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.10.0 to 16.11.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.10.0...v16.11.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .../IntegrationTests.Shared.Tests.csproj | 2 +- src/Directory.build.props | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj b/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj index 6e56de82dc..fcba19985a 100644 --- a/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj +++ b/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj @@ -8,7 +8,7 @@ - + all diff --git a/src/Directory.build.props b/src/Directory.build.props index 747e412b76..7601084204 100644 --- a/src/Directory.build.props +++ b/src/Directory.build.props @@ -34,7 +34,7 @@ - + From 569a72daad147fb02c8fb8e58ead193826810dac Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Aug 2021 01:57:40 +0000 Subject: [PATCH 2/4] build(deps): bump Microsoft.NET.Test.Sdk in /integrationtests Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.10.0 to 16.11.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.10.0...v16.11.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .../IntegrationTests.Shared.Tests.csproj | 2 +- src/Directory.build.props | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj b/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj index 6e56de82dc..fcba19985a 100644 --- a/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj +++ b/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj @@ -8,7 +8,7 @@ - + all diff --git a/src/Directory.build.props b/src/Directory.build.props index abfe6eae5a..f2989228cc 100644 --- a/src/Directory.build.props +++ b/src/Directory.build.props @@ -34,7 +34,7 @@ - + From 0aa2ebc3785eb3665bd0ba9853ccd1ebb085c713 Mon Sep 17 00:00:00 2001 From: Chris Pulman Date: Mon, 16 Aug 2021 03:04:10 +0100 Subject: [PATCH 3/4] Update ReactiveCommandTest.cs Is Executing timing seems marginal at 1ms so increased to 10ms --- .../Commands/ReactiveCommandTest.cs | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/ReactiveUI.Tests/Commands/ReactiveCommandTest.cs b/src/ReactiveUI.Tests/Commands/ReactiveCommandTest.cs index 2e0bce97ad..9ee43f1316 100644 --- a/src/ReactiveUI.Tests/Commands/ReactiveCommandTest.cs +++ b/src/ReactiveUI.Tests/Commands/ReactiveCommandTest.cs @@ -1158,11 +1158,13 @@ public async Task ReactiveCommandCreateFromTaskHandlesTaskExceptionAsync() var subj = new Subject(); var isExecuting = false; Exception? fail = null; - var fixture = ReactiveCommand.CreateFromTask(async _ => - { - await subj.Take(1); - throw new Exception("break execution"); - }); + var fixture = ReactiveCommand.CreateFromTask( + async _ => + { + await subj.Take(1); + throw new Exception("break execution"); + }); + fixture.IsExecuting.Subscribe(x => isExecuting = x); fixture.ThrownExceptions.Subscribe(ex => fail = ex); @@ -1175,8 +1177,8 @@ public async Task ReactiveCommandCreateFromTaskHandlesTaskExceptionAsync() subj.OnNext(Unit.Default); - // Wait 1 ms to allow execution to complete - await Task.Delay(1).ConfigureAwait(false); + // Wait 10 ms to allow execution to complete + await Task.Delay(10).ConfigureAwait(false); Assert.False(isExecuting); Assert.Equal("break execution", fail?.Message); From 23dd93496067099974aee890818a19c43aaaa468 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Aug 2021 02:21:20 +0000 Subject: [PATCH 4/4] build(deps): bump Microsoft.NET.Test.Sdk in /integrationtests Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.10.0 to 16.11.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.10.0...v16.11.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .../IntegrationTests.Shared.Tests.csproj | 2 +- src/Directory.build.props | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj b/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj index c5bbc3ffc2..d4b027411d 100644 --- a/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj +++ b/integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj @@ -8,7 +8,7 @@ - + all diff --git a/src/Directory.build.props b/src/Directory.build.props index 575df2094a..d408300b01 100644 --- a/src/Directory.build.props +++ b/src/Directory.build.props @@ -34,7 +34,7 @@ - +