From f918db24b19bded3c837456c11b3d0ca5c2293ba Mon Sep 17 00:00:00 2001 From: Konstantin S <3002068+HavenDV@users.noreply.github.com> Date: Fri, 29 Oct 2021 03:29:48 +1000 Subject: [PATCH 1/2] feat: Updated ReactiveUI.WinUI to use Microsoft.WindowsAppSDK. --- .github/workflows/ci-build.yml | 12 ++++++++++++ src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj | 14 ++++++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index bdbed3f3b5..ad4b88451e 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -37,6 +37,18 @@ jobs: $process.Start() $process.WaitForExit() + - name: Install Windows SDK 10.0.17763 + shell: pwsh + run: | + Invoke-WebRequest -Uri https://go.microsoft.com/fwlink/p/?LinkID=2033908 -OutFile winsdk.exe + $startInfo = New-Object System.Diagnostics.ProcessStartInfo + $startInfo.FileName = "winsdk.exe" + $startInfo.Arguments = "/norestart /quiet" + $process = New-Object System.Diagnostics.Process + $process.StartInfo = $startInfo + $process.Start() + $process.WaitForExit() + - name: Checkout uses: actions/checkout@v2 with: diff --git a/src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj b/src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj index 665d625051..32f9b49cc5 100644 --- a/src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj +++ b/src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj @@ -1,9 +1,8 @@ - + - net5.0-windows10.0.19041.0;net6.0-windows10.0.19041.0 + net5.0-windows10.0.17763.0;net6.0-windows10.0.17763.0 Contains the ReactiveUI platform specific extensions for WinUI Desktop ReactiveUI.WinUI.Desktop - win10-x86;win10-x64 HAS_WINUI mvvm;reactiveui;rx;reactive extensions;observable;LINQ;events;winui true @@ -11,9 +10,16 @@ - + + + + + + + + From be1d2d1c7e6445aa9efba6d191d4557c477e7a29 Mon Sep 17 00:00:00 2001 From: Glenn <5834289+glennawatson@users.noreply.github.com> Date: Fri, 29 Oct 2021 07:48:54 +1100 Subject: [PATCH 2/2] Update ci-build.yml --- .github/workflows/ci-build.yml | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index ad4b88451e..a91ec77761 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -35,19 +35,7 @@ jobs: $process = New-Object System.Diagnostics.Process $process.StartInfo = $startInfo $process.Start() - $process.WaitForExit() - - - name: Install Windows SDK 10.0.17763 - shell: pwsh - run: | - Invoke-WebRequest -Uri https://go.microsoft.com/fwlink/p/?LinkID=2033908 -OutFile winsdk.exe - $startInfo = New-Object System.Diagnostics.ProcessStartInfo - $startInfo.FileName = "winsdk.exe" - $startInfo.Arguments = "/norestart /quiet" - $process = New-Object System.Diagnostics.Process - $process.StartInfo = $startInfo - $process.Start() - $process.WaitForExit() + $process.WaitForExit() - name: Checkout uses: actions/checkout@v2