Propagate activate/deactivate to subviews on iOS (issue 719) #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses reactiveui#719, except for table/collection cells.
| @@ -452,6 +452,10 @@ public interface ICanActivate | |||
| IObservable<Unit> Deactivated { get; } | |||
| } | |||
|
|
|||
| internal interface ICanActivateView { | |||
There was a problem hiding this comment.
Would ICanForceManualActivation be a better name for this?
|
Hey @justin-factory, this is good. Do you know what the Mac story would be with this? (feel free to say "dunno lol") |
|
Yeah, I'm ignorant on how this would work for Mac. Sorry! |
|
Merged with fixups - thanks @justin-factory. We'll figure out more about how to handle this problem more Generally later |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will manually walk the subviews of a view controller and propagate the activation/deactivation state of that view controller. Note that this does not address how activation/deactivation should work for table/collection cells, but this is definitely a step forward.
Fixes #735