New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove ReactiveCommand abstract base class #19

Open
glennawatson opened this Issue Aug 22, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@glennawatson
Copy link
Contributor

glennawatson commented Aug 22, 2018

At the moment we have a abstract base class ReactiveCommand (without generics).

I propose we move all the explicit ICommand stuff into ReactiveCommand<TIn, TOut> and remove the ReactiveCommand abstract class.

This is because users are having binding issues with the abstract version of ReactiveCommand and our current thing we tell users is not to use the abstract ReactiveCommand class.

@worldbeater

This comment has been minimized.

Copy link
Member

worldbeater commented Nov 5, 2018

Absolutely worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment