Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tslib 2.3.0+ #6689

Closed
wSedlacek opened this issue Nov 25, 2021 · 3 comments · Fixed by #6692
Closed

Support tslib 2.3.0+ #6689

wSedlacek opened this issue Nov 25, 2021 · 3 comments · Fixed by #6692
Assignees
Labels
AGENDA ITEM

Comments

@wSedlacek
Copy link

@wSedlacek wSedlacek commented Nov 25, 2021

Bug Report

Current Behavior

"tslib": "~2.1.0"

tslib is set to ~2.1.0 which conflicts with ^2.3.0 used in other projects causing duplicate tslib modules

├─┬ @ngrx/component-store@13.0.1
│ └── tslib@2.3.1 deduped
├─┬ @ngrx/effects@13.0.1
│ └── tslib@2.3.1 deduped
├─┬ @ngrx/entity@13.0.1
│ └── tslib@2.3.1 deduped
├─┬ @ngrx/router-store@13.0.1
│ └── tslib@2.3.1 deduped
├─┬ @ngrx/store-devtools@13.0.1
│ └── tslib@2.3.1 deduped
├─┬ @ngrx/store@13.0.1
│ └── tslib@2.3.1 deduped
├─┬ ng-packagr@13.0.8
│ ├─┬ injection-js@2.4.0
│ │ └── tslib@2.3.1 deduped
│ ├─┬ rxjs@6.6.7
│ │ └── tslib@1.14.1
│ └── tslib@2.3.1 deduped
├─┬ rxjs@7.4.0
│ └── tslib@2.1.0
├── tslib@2.3.1

This duplication is adds ~0.6 Kb to a compiled project.

Expected behavior
tslib to be versioned such that there are not conflicts with other commonly used packages.

See:
ng-packagr/ng-packagr#2174 (comment)

Environment

  • RxJS version: ~7.4.0

Possible Solution
Perhaps a version of ^2.1.0 would be suitable to continue supporting older versions of packages (like Angular 12) but also supporting Angular 13

@benlesh
Copy link
Member

@benlesh benlesh commented Nov 29, 2021

Perhaps a version of ^2.1.0 would be suitable to continue supporting older versions of packages (like Angular 12) but also supporting Angular 13

This solution seems reasonable to me on it's face. I'm not sure if there are other implications. Generally TypeScript libraries aren't the best about honoring semver. 🤔

@benlesh benlesh self-assigned this Nov 29, 2021
@benlesh benlesh added the AGENDA ITEM label Nov 29, 2021
benlesh added a commit to benlesh/rxjs that referenced this issue Nov 29, 2021
@wSedlacek
Copy link
Author

@wSedlacek wSedlacek commented Nov 29, 2021

Thank you for the timely resolution!

@benlesh
Copy link
Member

@benlesh benlesh commented Nov 29, 2021

I have a lot of stuff to go through, so the next release may not be until the end of the week or later. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AGENDA ITEM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants