New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 #445

Merged
merged 7 commits into from Nov 2, 2017

Conversation

Projects
None yet
3 participants
@dustinsoftware
Collaborator

dustinsoftware commented Oct 16, 2017

The samples still need to be updated. This updates the built-in copy of React. The MVC Core sample was updated to support PropTypes and ES6 classes, both of which are required for React 16.

CommonJS imports are still not supported with built-in babel. I'm not sure how many people still need that functionality since compiling the client + server bundle with webpack ahead of time is a pretty stable alternative. So, it may be worth it to just deprecate on-the-fly JS compiler and move ahead with webpack-only builds.

@damanptyltd

This comment has been minimized.

damanptyltd commented Oct 27, 2017

This is great Dustin, would love to see this merged into a release.

@dustinsoftware dustinsoftware force-pushed the dustinsoftware:react-16 branch from e130fbb to 0bd9e36 Oct 27, 2017

dustinsoftware added some commits Oct 27, 2017

@dustinsoftware

This comment has been minimized.

Collaborator

dustinsoftware commented Oct 27, 2017

@Daniel15 this is almost ready to go. I just have to finish getting the webpack sample working before this should be merged, everything else is ready for review

dustinsoftware added some commits Oct 31, 2017

@dustinsoftware

This comment has been minimized.

Collaborator

dustinsoftware commented Oct 31, 2017

@Daniel15 this should be good to go now.

@Daniel15

This comment has been minimized.

Member

Daniel15 commented Nov 2, 2017

Thank you @dustinsoftware! I'll try to push out a release this weekend.

@Daniel15 Daniel15 merged commit 209de13 into reactjs:master Nov 2, 2017

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@Daniel15

This comment has been minimized.

Member

Daniel15 commented Nov 8, 2017

Released this today as version 3.2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment