New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI with Azure Pipelines #642

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
4 participants
@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Dec 21, 2018

No description provided.

@Daniel15 Daniel15 self-assigned this Dec 21, 2018

@Daniel15

This comment has been minimized.

Copy link
Member

Daniel15 commented Dec 21, 2018

Need to work out what's up with this:

src\React.Sample.Mvc4\React.Sample.Mvc4.csproj(196,11): Error MSB4226: The imported project "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\\WebApplications\Microsoft.WebApplication.targets" was not found. Also, tried to find "\WebApplications\Microsoft.WebApplication.targets" in the fallback search path(s) for $(VSToolsPath) - "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v15.0" . These search paths are defined in "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\MSBuild.exe.Config". Confirm that the path in the <Import> declaration is correct, and that the file exists on disk in one of the search paths.
src\React.Sample.Cassette\React.Sample.Cassette.csproj(208,11): Error MSB4226: The imported project "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\\WebApplications\Microsoft.WebApplication.targets" was not found. Also, tried to find "\WebApplications\Microsoft.WebApplication.targets" in the fallback search path(s) for $(VSToolsPath) - "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v15.0" . These search paths are defined in "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\MSBuild.exe.Config". Confirm that the path in the <Import> declaration is correct, and that the file exists on disk in one of the search paths.

@btholt @hross Do you know what's up with this? On my computer I can see this file at C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\WebApplications\Microsoft.WebApplication.targets

I wonder if that's because I have both Visual Studio 2015 and Visual Studio 2017 installed... That'd explain why it works on AppVeyor too (AFAIK they have all the Visual Studio versions in a single image). Maybe this path needs to be tweaked for VS2017.

@dustinsoftware

This comment has been minimized.

Copy link
Collaborator

dustinsoftware commented Dec 21, 2018

@Daniel15

This comment has been minimized.

Copy link
Member

Daniel15 commented Dec 21, 2018

@dustinsoftware - Yeah, just trying it out at the moment. It looks really good though. AppVeyor is slow at times, and Azure Pipelines uses some of the newer GitHub integration features (like the "Checks" tab).

@dustinsoftware

This comment has been minimized.

Copy link
Collaborator

dustinsoftware commented Dec 29, 2018

@Daniel15 the build passed on both AppVeyor and Azure pipelines, but you should merge so you can confirm the Azure pipelines config is set up properly (also add me please to the Azure project please?)

@Daniel15

This comment has been minimized.

Copy link
Member

Daniel15 commented Dec 29, 2018

@dustinsoftware dustinsoftware force-pushed the azure-pipelines branch from 0907e40 to 755d30c Dec 31, 2018

@btholt

This comment has been minimized.

Copy link

btholt commented Dec 31, 2018

I'll ping some people on the DevOps team.

@hross

This comment has been minimized.

Copy link

hross commented Jan 2, 2019

Looks like they already figured out that the paths were hard coded in some of the csproj files and updated with the correct variables.

@Daniel15

This comment has been minimized.

Copy link
Member

Daniel15 commented Jan 2, 2019

Yeah this looks like it's working fine now. I just need to work out how to publish the packages to a development package repo. Currently we use AppVeyor, which automatically hosts all the .nupkg files. We can work that out separately though.

@Daniel15 Daniel15 merged commit d3a1235 into master Jan 2, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
deploy/netlify Deploy preview ready!
Details

@Daniel15 Daniel15 deleted the azure-pipelines branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment