Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Fragements page #54

Merged
merged 9 commits into from May 29, 2019

Conversation

Projects
None yet
3 participants
@ph1p
Copy link
Member

commented May 7, 2019

No description provided.

@tesseralis tesseralis referenced this pull request May 7, 2019

Open

German Translation Progress #1

30 of 88 tasks complete
@netlify

This comment has been minimized.

Copy link

commented May 7, 2019

Deploy preview for de-reactjs ready!

Built with commit 090821c

https://deploy-preview-54--de-reactjs.netlify.com

ph1p added some commits May 11, 2019

Update fragment translation
Signed-off-by: Phil <phil@capshake.com>
@tamarau
Copy link
Contributor

left a comment

Hi,
Tried myself with reviewing your PR for the first time, so please feel free to use my suggestions or not and maybe get a second person to look over the PR ☺️

Show resolved Hide resolved content/docs/fragments.md Outdated
Show resolved Hide resolved content/docs/fragments.md Outdated
Show resolved Hide resolved content/docs/fragments.md Outdated
Show resolved Hide resolved content/docs/fragments.md Outdated
Show resolved Hide resolved content/docs/fragments.md Outdated
Show resolved Hide resolved content/docs/fragments.md Outdated
@EyMaddis

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

It seems I did not hit send on my PR review...

@ph1p

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

Thanks @EyMaddis ! (:

@EyMaddis

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

My PR does not mean that @tamarau's is not as valid. (Scroll up a bit, @ph1p ) :)

@ph1p

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

Hi,
Tried myself with reviewing your PR for the first time, so please feel free to use my suggestions or not and maybe get a second person to look over the PR ☺️

I really appreciate it! I try to translate as much as possible at the react docs. Nothing is carved in stone and everytime something is wrong, a person can open a new PR and correct it.

@ph1p

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

My PR does not mean that @tamarau's is not as valid. (Scroll up a bit, @ph1p ) :)

I've seen it ^^ Thanks

ph1p and others added some commits May 29, 2019

Update content/docs/fragments.md
Co-Authored-By: Tamara <t_und@hotmail.com>
Update content/docs/fragments.md
Co-Authored-By: Tamara <t_und@hotmail.com>
Update content/docs/fragments.md
Co-Authored-By: Madd.is <github@madd.is>
Update content/docs/fragments.md
Co-Authored-By: Madd.is <github@madd.is>
Update content/docs/fragments.md
Co-Authored-By: Madd.is <github@madd.is>

@ph1p ph1p merged commit 7efe8d2 into master May 29, 2019

4 of 5 checks passed

Pages changed 339 new files uploaded
Details
Header rules 331 header rules processed
Details
Mixed content No mixed content detected
Details
Redirect rules 343 redirect rules processed
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.