New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components and Props translation #10

Merged
merged 11 commits into from Feb 2, 2019

Conversation

Projects
None yet
6 participants
@EzequielMonforte
Copy link
Contributor

EzequielMonforte commented Jan 31, 2019

Components and props
Related to #4

@EzequielMonforte EzequielMonforte changed the title WIP Components and Props WIP Components and Props translation Jan 31, 2019

@tesseralis tesseralis referenced this pull request Jan 31, 2019

Open

Spanish Translation Progress #4

72 of 87 tasks complete

@EzequielMonforte EzequielMonforte changed the title WIP Components and Props translation Components and Props translation Jan 31, 2019

@tesseralis tesseralis requested review from alejandronanez and dmoralesm Feb 1, 2019

@EzequielMonforte

This comment has been minimized.

Copy link
Contributor Author

EzequielMonforte commented Feb 1, 2019

Corrections applied

@alejandronanez
Copy link
Member

alejandronanez left a comment

Hey @EzequielMonforte, I left some comments that are worth addressing before merging this PR.

Thanks!

Show resolved Hide resolved content/docs/components-and-props.md Outdated
Show resolved Hide resolved content/docs/components-and-props.md Outdated
Show resolved Hide resolved content/docs/components-and-props.md Outdated
Show resolved Hide resolved content/docs/components-and-props.md Outdated
Show resolved Hide resolved content/docs/components-and-props.md Outdated
Show resolved Hide resolved content/docs/components-and-props.md Outdated
@alejandronanez
Copy link
Member

alejandronanez left a comment

Hi @EzequielMonforte, thanks for addressing all the comments in record time!

This is looking good - thanks for contributing!

@alejandronanez alejandronanez merged commit a4efd8e into reactjs:master Feb 2, 2019

@EzequielMonforte EzequielMonforte deleted the EzequielMonforte:translate-components-props branch Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment