New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists and Keys Translation #22

Merged
merged 18 commits into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@EzequielMonforte
Copy link
Contributor

EzequielMonforte commented Feb 1, 2019

#18

Need help translating words : IDs, array, keys

@EzequielMonforte EzequielMonforte changed the title WIP: List sand Keys WIP: Lists and Keys Feb 1, 2019

@EzequielMonforte EzequielMonforte changed the title WIP: Lists and Keys Lists and Keys Feb 1, 2019

@EzequielMonforte EzequielMonforte changed the title Lists and Keys Lists and Keys Translation Feb 1, 2019

Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated

Aqui esta una [explicacion en profundidad sobre porque las keys son necesarias](/docs/reconciliation.html#recursing-on-children) si estas interesado en aprender mas.
Aquí esta una [explicación en profundidad sobre porque las keys son necesarias](/docs/reconciliation.html#recursing-on-children) si estas interesado en aprender más.

This comment has been minimized.

@gariasf

gariasf Feb 2, 2019

Perhaps Aquí hay instead of Aquí está

This comment has been minimized.

@EzequielMonforte

EzequielMonforte Feb 2, 2019

Author Contributor

In the original text it is Here is, so for me it should be Aquí está .
It should be Here there is to be translated in Aquí hay in my opinion. What do you think?

Show resolved Hide resolved content/docs/lists-and-keys.md Outdated

For example, if you [extract](/docs/components-and-props.html#extracting-components) a `ListItem` component, you should keep the key on the `<ListItem />` elements in the array rather than on the `<li>` element in the `ListItem` itself.
Por ejemplo, si [extraes](/docs/components-and-props.html#extracting-components) un componente `ListItem`, debes mantener la key en el elemnto `<ListItem />` en el array en lugar de en el elemento `<li>` en el `ListItem` en si mismo.

This comment has been minimized.

@gariasf

gariasf Feb 2, 2019

I think this can be better translated this way:

... debes mantener la key en los elementos <ListItem /> en el array en lugar de en los elementos <li> en el ListItem en sí.

Regardless of that, note elemnto before <ListItem />, it should be elemento/s
Note

This comment has been minimized.

@EzequielMonforte

EzequielMonforte Feb 2, 2019

Author Contributor

IMO

...derberias mantener la key en los elementos <ListItem /> en el array en lugar de en el elemento <li> en el <ListItem /> en si mismo.

Sounds better. What do you think?

Show resolved Hide resolved content/docs/lists-and-keys.md Outdated

**Ejemplo: Uso Incorrecto de Key**

```javascript{4,5,14,15}
function ListItem(props) {
const value = props.value;
return (
// Wrong! There is no need to specify the key here:
// Mal! No es necesario especificar la key aquí:

This comment has been minimized.

@gariasf

gariasf Feb 2, 2019

My suggestion: // Mal! Aquí no es necesario especificar la key:

This comment has been minimized.

@EzequielMonforte

EzequielMonforte Feb 2, 2019

Author Contributor

@gariasf what about No hay necesidad de especificar la key

@@ -156,7 +156,7 @@ function ListItem(props) {
function NumberList(props) {
const numbers = props.numbers;
const listItems = numbers.map((number) =>
// Wrong! The key should have been specified here:
// Mal! La key debería haber sido especificada aquí:

This comment has been minimized.

@gariasf

gariasf Feb 2, 2019

My suggestion: // Mal! Aquí la key debería haber sido especificada:

@@ -177,14 +177,14 @@ ReactDOM.render(

```javascript{2,3,9,10}
function ListItem(props) {
// Correct! There is no need to specify the key here:
// Correcto! No hay necesidad de especificar la key aquí:

This comment has been minimized.

@gariasf

gariasf Feb 2, 2019

My suggestion: // Correcto! Aquí no hay necesidad de especificar la key:

Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
@gariasf

This comment has been minimized.

Copy link

gariasf commented Feb 2, 2019

Hey! I left some reviews on the first commit and GitHub marks them as "outdated", but they are new nonetheless.

@EzequielMonforte

This comment has been minimized.

Copy link
Contributor Author

EzequielMonforte commented Feb 5, 2019

I've done some corrections. Please tell me if there is something else to correct

@tesseralis tesseralis referenced this pull request Feb 5, 2019

Open

Spanish Translation Progress #4

72 of 87 tasks complete

@carburo carburo reopened this Feb 5, 2019

@carburo
Copy link
Member

carburo left a comment

Hi, @EzequielMonforte. Judging by your comment I think you closed the PR by mistake. I made some suggestions and fix some typos. Thank you for your contribution!

Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated
Show resolved Hide resolved content/docs/lists-and-keys.md Outdated

carburo and others added some commits Feb 5, 2019

Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
Update content/docs/lists-and-keys.md
Co-Authored-By: EzequielMonforte <ezequielmonforte@gmail.com>
@EzequielMonforte

This comment has been minimized.

Copy link
Contributor Author

EzequielMonforte commented Feb 5, 2019

Thanks @carburo ! I've applied some of your suggestions

@carburo

carburo approved these changes Feb 5, 2019

@carburo

This comment has been minimized.

Copy link
Member

carburo commented Feb 5, 2019

Looks good to me. Merging 🚀

@carburo carburo merged commit 5de647c into reactjs:master Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment