Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Test Utilities Page #16

Merged
merged 11 commits into from Mar 3, 2019

Conversation

Projects
None yet
4 participants
@Lukereonal
Copy link
Contributor

Lukereonal commented Feb 11, 2019

Mohon reviewnya guys 馃檹馃徎

@Lukereonal Lukereonal referenced this pull request Feb 11, 2019

Open

Indonesian Translation Progress #1

12 of 87 tasks complete
@spondbob
Copy link

spondbob left a comment

Refer to this discussion once it is added to glossary.

Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
@regalius
Copy link
Member

regalius left a comment

Looks like just need to adjust several common terms and we're good to go 馃帀

Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
Show resolved Hide resolved content/docs/addons-test-utils.md Outdated

@regalius regalius requested review from gedeagas and arfianadam Feb 12, 2019

@regalius
Copy link
Member

regalius left a comment

1 last thing mas @Lukereonal , please translate strings inside code blocks to make it uniform across pages and I think, we're good to go 馃憤

@Lukereonal

This comment has been minimized.

Copy link
Contributor Author

Lukereonal commented Feb 15, 2019

@regalius sorry i missed that, I already translate the string 馃檹馃徎

@regalius

This comment has been minimized.

Copy link
Member

regalius commented Feb 16, 2019

Sorry, noticed another thing mas @Lukereonal , capitalized Anda (and other kata sapaan) should only be in the context of kata sapaan, so:

  • Anda harus melakukan ...
  • ...membuat komponen anda

Because in the case of no. 2 anda is attached to the noun as kepemilikan, so it's not necessary to capitalize it 馃槃

@Lukereonal

This comment has been minimized.

Copy link
Contributor Author

Lukereonal commented Feb 16, 2019

@regalius Thanks for the input, I already change some Anda that i think is supposed to be a noun. But please check again because i'm not 100% sure especially the last Anda on the page 馃槄

@regalius
Copy link
Member

regalius left a comment

Nice, LGTM from me @Lukereonal ! Thank you so much for the hardwork 馃帀

@gedeagas @arfianadam any comments before we're merging this PR?

Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
Show resolved Hide resolved content/docs/addons-test-utils.md Outdated
@Lukereonal

This comment has been minimized.

Copy link
Contributor Author

Lukereonal commented Feb 18, 2019

@arfianadam Thanks for the review, I already fix it please let me know if there anything else 馃檹馃徎

@netlify

This comment has been minimized.

Copy link

netlify bot commented Feb 18, 2019

Deploy preview for idreactjs ready!

Built with commit 8533b7a

https://deploy-preview-16--idreactjs.netlify.com

@regalius

This comment has been minimized.

Copy link
Member

regalius commented Feb 24, 2019

This PR looks like it's ready to be merged what do you think guys? @gedeagas @arfianadam

@netlify

This comment has been minimized.

Copy link

netlify bot commented Feb 25, 2019

Deploy preview for id-reactjs ready!

Built with commit 8533b7a

https://deploy-preview-16--id-reactjs.netlify.com

@regalius regalius merged commit 4547fd1 into reactjs:master Mar 3, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details
@regalius

This comment has been minimized.

Copy link
Member

regalius commented Mar 3, 2019

It got LGTM from @arfianadam & @gedeagas, and merged. Thanks for the contribution mas @Lukereonal ! 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.