Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added translation on reactdomserver page #29

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@RiftSplitter
Copy link

RiftSplitter commented Feb 16, 2019

No description provided.

@regalius regalius requested review from gedeagas , arfianadam and regalius Feb 16, 2019

@regalius
Copy link
Member

regalius left a comment

Thanks for the contribution @RiftSplitter ,I think just need to adjust several things and we're good to go! 🎉

Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
Show resolved Hide resolved content/docs/reference-react-dom-server.md Outdated
@regalius

This comment has been minimized.

Copy link
Member

regalius commented Mar 3, 2019

Hi mas @RiftSplitter , any update regarding this PR? 😄

@tesseralis tesseralis referenced this pull request Mar 3, 2019

Open

Indonesian Translation Progress #1

12 of 87 tasks complete
@RiftSplitter

This comment has been minimized.

Copy link
Author

RiftSplitter commented Mar 4, 2019

Hi @regalius sorry for the late reply and update, I've updated and changed some of the words and capitalization based on suggestions from you and @spondbob. Please review it. 🙏

@netlify

This comment has been minimized.

Copy link

netlify bot commented Mar 4, 2019

Deploy preview for idreactjs ready!

Built with commit c9c73bc

https://deploy-preview-29--idreactjs.netlify.com

@netlify

This comment has been minimized.

Copy link

netlify bot commented Mar 4, 2019

Deploy preview for id-reactjs ready!

Built with commit c9c73bc

https://deploy-preview-29--id-reactjs.netlify.com

@regalius
Copy link
Member

regalius left a comment

LGTM from me, Thanks for the contribution @RiftSplitter ! 🎉

Any comments? @arfianadam @gedeagas @rizafahmi

@rizafahmi
Copy link
Contributor

rizafahmi left a comment

Just minor suggestion


If you plan to use React on the client to make the markup interactive, do not use this method. Instead, use [`renderToString`](#rendertostring) on the server and [`ReactDOM.hydrate()`](/docs/react-dom.html#hydrate) on the client.
Jika Anda berencana untuk menggunakan React di dalam klien untuk membuat *markup* yang interaktif, Anda tidak disarankan untuk menggunakan *method* ini. Sebaiknya, gunakan [`renderToString`](#rendertostring) di dalam server dan gunakan [`ReactDOM.hydrate()`](/docs/react-dom.html#hydrate) di klien.

This comment has been minimized.

@rizafahmi

rizafahmi Mar 14, 2019

Contributor
  • "di dalam klien" -> "di sisi klien"
  • "di dalam server" -> "di sisi server"

This comment has been minimized.

@RiftSplitter

RiftSplitter Mar 17, 2019

Author

Hi @rizafahmi, I've just updated the translation again according to your suggestion. Thanks for the suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.