Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated Hooks at a Glance #34

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@grikomsn
Copy link

grikomsn commented Feb 19, 2019

This is a translation PR for the Hooks at a Glance page. Heavy review and changes are needed. Here are some somewhat important notes:

  • Lifecycle, data fetching, subscriptions, subscribe, unsubscribe, and other words are kept as is
  • Hooks and Hook are all italicized, which previously aren't
  • Effect Hook is translated to Hook Effect, State Hook turns to Hook State
  • Several sentence adjustment far from original text for better understanding
@netlify

This comment has been minimized.

Copy link

netlify bot commented Feb 19, 2019

Deploy preview for idreactjs ready!

Built with commit 3b2653b

https://deploy-preview-34--idreactjs.netlify.com

@spondbob

This comment has been minimized.

Copy link

spondbob commented on content/docs/hooks-overview.md in 3a1a228 Feb 19, 2019

diingkan typo

@spondbob

This comment has been minimized.

Copy link

spondbob commented on content/docs/hooks-overview.md in 3a1a228 Feb 19, 2019

memanggin typo

@grikomsn

This comment has been minimized.

Copy link
Author

grikomsn commented Feb 19, 2019

So much typos, I should sleep more often. I'll revise some typos and others. 😄

grikomsn added a commit to grikomsn/id.reactjs.org that referenced this pull request Feb 19, 2019

@grikomsn grikomsn force-pushed the grikomsn:master branch from ab76e29 to ddc557d Feb 19, 2019

@grikomsn

This comment has been minimized.

Copy link
Author

grikomsn commented Feb 20, 2019

Corrected, thanks for the heads up. 😄

@grikomsn

This comment has been minimized.

Copy link
Author

grikomsn commented Feb 21, 2019

Pardon for asking, but how long is the review process for each PR?

cc @regalius @arfianadam @gedeagas

@regalius

This comment has been minimized.

Copy link
Member

regalius commented Feb 24, 2019

So sorry @grikomsn I had a busy week and haven't been able to review the PRs, I assume both @gedeagas and @arfianadam had busy week also, will review now.. 🙏

@regalius
Copy link
Member

regalius left a comment

Hi @grikomsn , Thank you for the contribution 🎉 , so sorry I had a busy week and wasn't able to review your PR, There's several terms and diction that I think need another consideration (and I need your opinion about it) and it'll be good to go!

Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved content/docs/hooks-overview.md Outdated
Show resolved Hide resolved yarn.lock Outdated
@netlify

This comment has been minimized.

Copy link

netlify bot commented Feb 24, 2019

Deploy preview for id-reactjs ready!

Built with commit 3b2653b

https://deploy-preview-34--id-reactjs.netlify.com

@grikomsn

This comment has been minimized.

Copy link
Author

grikomsn commented Feb 24, 2019

This goes to show that I can't write in my native language properly 😅

@regalius
Copy link
Member

regalius left a comment

LGTM from me.. Nice Work @grikomsn ! No worries lol

Thanks for the contribution! 🎉

Any comments guys @arfianadam @gedeagas ?

Edited: Btw please resolve the conflict with the upstream regarding the yarn.lock before we can merge this PR 😄

@tesseralis tesseralis referenced this pull request Mar 3, 2019

Open

Indonesian Translation Progress #1

12 of 87 tasks complete
@gedeagas

This comment has been minimized.

Copy link
Member

gedeagas commented Mar 18, 2019

LGTM for the translation. can you remove the yarn lock @grikomsn ?

@grikomsn

This comment has been minimized.

Copy link
Author

grikomsn commented Mar 18, 2019

I have already removed the yarn.lock file, but somehow the build fails. Pushed an empty commit to trigger the build.

Force pushed my work with modified and cherrypicked commits. Let's see if it works. 😢

grikomsn and others added some commits Mar 18, 2019

Update content/docs/hooks-overview.md
Co-Authored-By: grikomsn <grikomsn@gmail.com>
Apply suggestions from code review
Co-Authored-By: grikomsn <grikomsn@gmail.com>
Apply suggestions from code review
Co-Authored-By: grikomsn <grikomsn@gmail.com>

@grikomsn grikomsn force-pushed the grikomsn:master branch from c253b6e to 3b2653b Mar 18, 2019

@grikomsn

This comment has been minimized.

Copy link
Author

grikomsn commented Mar 18, 2019

Checks passed! Probably best that @regalius, @gedeagas, @spondbob, and other reviewers to re-review the commits again since I force pushed the commits. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.