New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that tag name of SVG would be lowercase #138

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@tsuyoshiwada
Contributor

tsuyoshiwada commented Aug 14, 2017

Hi @Daniel15.

There is a bug where the name of the tag which should be a camel case becomes all lowercase when converting SVG.

- Received: clippath, lineargradient
+ Expected: clipPath, linearGradient

Conversion processing was added by referring to the SVG tag list of MDN.

@ritz078

This comment has been minimized.

Show comment
Hide comment
@ritz078

ritz078 Sep 4, 2017

Hi @tsuyoshiwada Is this update available in tsuyoshiwada/htmltojsx ?

ritz078 commented Sep 4, 2017

Hi @tsuyoshiwada Is this update available in tsuyoshiwada/htmltojsx ?

@tsuyoshiwada

This comment has been minimized.

Show comment
Hide comment
@tsuyoshiwada

tsuyoshiwada Sep 4, 2017

Contributor

Hi @ritz078. Yes! tsuyoshiwada/htmltojsx already apply the this patch 👍

You can check the behavior of the following page!
https://tsuyoshiwada.github.io/svg-to-jsx-with-gui/

Contributor

tsuyoshiwada commented Sep 4, 2017

Hi @ritz078. Yes! tsuyoshiwada/htmltojsx already apply the this patch 👍

You can check the behavior of the following page!
https://tsuyoshiwada.github.io/svg-to-jsx-with-gui/

@ritz078

This comment has been minimized.

Show comment
Hide comment
@ritz078

ritz078 Sep 4, 2017

Great. Thanks.

ritz078 commented Sep 4, 2017

Great. Thanks.

@Daniel15 Daniel15 merged commit 024a6e6 into reactjs:master Sep 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Daniel15

This comment has been minimized.

Show comment
Hide comment
@Daniel15

Daniel15 Sep 5, 2017

Member

Released as 0.3.0 😃

Member

Daniel15 commented Sep 5, 2017

Released as 0.3.0 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment