From eca3e8d1b378497223114d26829916f749ac6550 Mon Sep 17 00:00:00 2001 From: Harry Bachrach Date: Thu, 25 Aug 2022 22:05:37 -0700 Subject: [PATCH 1/6] Switch to GitHub Actions for testing See here for an argument as to why to do so --- .github/workflows/ruby.yml | 40 +++++++++++++++++++++++++ .travis.yml | 60 -------------------------------------- 2 files changed, 40 insertions(+), 60 deletions(-) create mode 100644 .github/workflows/ruby.yml delete mode 100644 .travis.yml diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml new file mode 100644 index 00000000..21d167db --- /dev/null +++ b/.github/workflows/ruby.yml @@ -0,0 +1,40 @@ +# This workflow uses actions that are not certified by GitHub. +# They are provided by a third-party and are governed by +# separate terms of service, privacy policy, and support +# documentation. +# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake +# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby + +name: Ruby +on: [push, pull_request] +jobs: + test: + strategy: + fail-fast: false + matrix: + ruby: + - 2.7.0 + - 2.6.5 + - 2.5.7 + - jruby-9.1.17.0 + gemfile: + # These have webpacker: + - rails_5.2_no_sprockets + - rails_5.2_no_sprockets_webpacker_3 + - rails_5.2_no_sprockets_webpacker_4 + # These don't have webpacker: + - rails_5.2_sprockets_3 + - rails_5.2_sprockets_4 + runs-on: ubuntu-latest + env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps + BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-node@v3 + - uses: ruby/setup-ruby@v1 + with: + ruby-version: ${{ matrix.ruby }} + # TODO: Impalement caching + # bundler-cache: true + - run: bundle install + - run: bundle exec rake test diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 487ad30e..00000000 --- a/.travis.yml +++ /dev/null @@ -1,60 +0,0 @@ -language: ruby -sudo: required -dist: trusty -addons: - chrome: stable -cache: - bundler: true - yarn: true -rvm: - - 2.7.0 - - 2.6.5 - - 2.5.7 - - jruby-9.1.9.0 - -gemfile: - # These have webpacker: - - gemfiles/rails_5.2_no_sprockets.gemfile - - gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile - - gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile - # These don't have webpacker: - - gemfiles/rails_5.2_sprockets_3.gemfile - - gemfiles/rails_5.2_sprockets_4.gemfile - -matrix: - fast_finish: true - exclude: - # Oldest rails does not run on ruby 2.6 - - rvm: 2.6.5 - - rvm: 2.5.7 - - rvm: jruby-9.1.9.0 - - include: - # Newest gemfiles for universal testing - - rvm: 2.6.5 - gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile - - rvm: 2.6.5 - gemfile: gemfiles/rails_5.2_sprockets_4.gemfile - - rvm: 2.5.7 - gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile - - rvm: 2.5.7 - gemfile: gemfiles/rails_5.2_sprockets_4.gemfile - - rvm: jruby-9.1.9.0 - gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile - - rvm: jruby-9.1.9.0 - gemfile: gemfiles/rails_5.2_sprockets_4.gemfile - - allow_failures: - - rvm: jruby-9.1.9.0 - gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile - - rvm: jruby-9.1.9.0 - gemfile: gemfiles/rails_5.2_sprockets_4.gemfile - -before_install: - # Repo for Yarn - - sudo apt-key adv --fetch-keys http://dl.yarnpkg.com/debian/pubkey.gpg - - echo "deb http://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list - - sudo apt-get update -qq - - sudo apt-get install -y -qq yarn - - gem update --system - - google-chrome-stable --headless --disable-gpu --remote-debugging-port=9222 http://localhost & From 255f82f1dae1a97b53c65afed4e309aab0390d1b Mon Sep 17 00:00:00 2001 From: Harry Bachrach Date: Sun, 11 Sep 2022 14:44:38 -0700 Subject: [PATCH 2/6] Update `rails` past 5.2.5 to work around yanked mimemagic See these links for context: * https://github.com/rails/rails/issues/41750 * https://rubyonrails.org/2021/3/26/marcel-upgrade-releases --- gemfiles/rails_5.2_no_sprockets.gemfile.lock | 136 ++++++++--------- ..._5.2_no_sprockets_webpacker_3.gemfile.lock | 138 +++++++++--------- ..._5.2_no_sprockets_webpacker_4.gemfile.lock | 138 +++++++++--------- gemfiles/rails_5.2_sprockets_3.gemfile.lock | 130 ++++++++--------- gemfiles/rails_5.2_sprockets_4.gemfile.lock | 132 +++++++++-------- 5 files changed, 342 insertions(+), 332 deletions(-) diff --git a/gemfiles/rails_5.2_no_sprockets.gemfile.lock b/gemfiles/rails_5.2_no_sprockets.gemfile.lock index 2b2beb8c..32b16191 100644 --- a/gemfiles/rails_5.2_no_sprockets.gemfile.lock +++ b/gemfiles/rails_5.2_no_sprockets.gemfile.lock @@ -1,7 +1,7 @@ PATH remote: .. specs: - react-rails (2.6.1) + react-rails (2.6.2) babel-transpiler (>= 0.7.0) connection_pool execjs @@ -11,43 +11,43 @@ PATH GEM remote: http://rubygems.org/ specs: - actioncable (5.2.4.1) - actionpack (= 5.2.4.1) + actioncable (5.2.8.1) + actionpack (= 5.2.8.1) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailer (5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) + actionmailer (5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (5.2.4.1) - actionview (= 5.2.4.1) - activesupport (= 5.2.4.1) + actionpack (5.2.8.1) + actionview (= 5.2.8.1) + activesupport (= 5.2.8.1) rack (~> 2.0, >= 2.0.8) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.2) - actionview (5.2.4.1) - activesupport (= 5.2.4.1) + actionview (5.2.8.1) + activesupport (= 5.2.8.1) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.3) - activejob (5.2.4.1) - activesupport (= 5.2.4.1) + activejob (5.2.8.1) + activesupport (= 5.2.8.1) globalid (>= 0.3.6) - activemodel (5.2.4.1) - activesupport (= 5.2.4.1) - activerecord (5.2.4.1) - activemodel (= 5.2.4.1) - activesupport (= 5.2.4.1) + activemodel (5.2.8.1) + activesupport (= 5.2.8.1) + activerecord (5.2.8.1) + activemodel (= 5.2.8.1) + activesupport (= 5.2.8.1) arel (>= 9.0) - activestorage (5.2.4.1) - actionpack (= 5.2.4.1) - activerecord (= 5.2.4.1) - marcel (~> 0.3.1) - activesupport (5.2.4.1) + activestorage (5.2.8.1) + actionpack (= 5.2.8.1) + activerecord (= 5.2.8.1) + marcel (~> 1.0.0) + activesupport (5.2.8.1) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) @@ -84,19 +84,19 @@ GEM coffee-script-source execjs coffee-script-source (1.12.2) - concurrent-ruby (1.1.5) + concurrent-ruby (1.1.10) connection_pool (2.2.2) - crass (1.0.5) + crass (1.0.6) docile (1.1.5) - erubi (1.9.0) + erubi (1.11.0) es5-shim-rails (4.0.1) actionpack (>= 3.1) railties (>= 3.1) execjs (2.7.0) ffi (1.11.3) formatador (0.2.5) - globalid (0.4.2) - activesupport (>= 4.2.0) + globalid (0.6.0) + activesupport (>= 5.0) guard (2.16.1) formatador (>= 0.2.4) listen (>= 2.7, < 4.0) @@ -110,7 +110,7 @@ GEM guard-minitest (2.4.6) guard-compat (~> 1.2) minitest (>= 3.0) - i18n (1.7.0) + i18n (1.12.0) concurrent-ruby (~> 1.0) jbuilder (2.9.1) activesupport (>= 4.2.0) @@ -118,23 +118,22 @@ GEM listen (3.0.8) rb-fsevent (~> 0.9, >= 0.9.4) rb-inotify (~> 0.9, >= 0.9.7) - loofah (2.4.0) + loofah (2.18.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) lumberjack (1.0.13) mail (2.7.1) mini_mime (>= 0.1.1) - marcel (0.3.3) - mimemagic (~> 0.3.2) + marcel (1.0.2) method_source (0.9.2) - mimemagic (0.3.10) - mini_mime (1.0.2) - mini_portile2 (2.4.0) - minitest (5.13.0) + mini_mime (1.1.2) + mini_portile2 (2.8.0) + minitest (5.16.3) nenv (0.3.0) - nio4r (2.5.2) - nokogiri (1.10.7) - mini_portile2 (~> 2.4.0) + nio4r (2.5.8) + nokogiri (1.13.8) + mini_portile2 (~> 2.8.0) + racc (~> 1.4) notiffany (0.1.3) nenv (~> 0.1) shellany (~> 0.0) @@ -145,34 +144,35 @@ GEM byebug (~> 11.0) pry (~> 0.10) public_suffix (4.0.2) - rack (2.0.8) + racc (1.6.0) + rack (2.2.4) rack-test (1.1.0) rack (>= 1.0, < 3) - rails (5.2.4.1) - actioncable (= 5.2.4.1) - actionmailer (= 5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) - activemodel (= 5.2.4.1) - activerecord (= 5.2.4.1) - activestorage (= 5.2.4.1) - activesupport (= 5.2.4.1) + rails (5.2.8.1) + actioncable (= 5.2.8.1) + actionmailer (= 5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) + activemodel (= 5.2.8.1) + activerecord (= 5.2.8.1) + activestorage (= 5.2.8.1) + activesupport (= 5.2.8.1) bundler (>= 1.3.0) - railties (= 5.2.4.1) + railties (= 5.2.8.1) sprockets-rails (>= 2.0.0) rails-dom-testing (2.0.3) activesupport (>= 4.2.0) nokogiri (>= 1.6) - rails-html-sanitizer (1.3.0) + rails-html-sanitizer (1.4.3) loofah (~> 2.3) - railties (5.2.4.1) - actionpack (= 5.2.4.1) - activesupport (= 5.2.4.1) + railties (5.2.8.1) + actionpack (= 5.2.8.1) + activesupport (= 5.2.8.1) method_source rake (>= 0.8.7) thor (>= 0.19.0, < 2.0) - rake (13.0.1) + rake (13.0.6) rb-fsevent (0.10.3) rb-inotify (0.10.1) ffi (~> 1.0) @@ -187,26 +187,29 @@ GEM json (>= 1.8, < 3) simplecov-html (~> 0.10.0) simplecov-html (0.10.2) - sprockets (4.0.0) + sprockets (4.1.1) concurrent-ruby (~> 1.0) rack (> 1, < 3) - sprockets-rails (3.2.1) - actionpack (>= 4.0) - activesupport (>= 4.0) + sprockets-rails (3.4.2) + actionpack (>= 5.2) + activesupport (>= 5.2) sprockets (>= 3.0.0) test-unit (2.5.5) - thor (1.0.1) + thor (1.2.1) thread_safe (0.3.6) tilt (2.0.10) - tzinfo (1.2.6) + turbolinks (5.2.1) + turbolinks-source (~> 5.2) + turbolinks-source (5.2.0) + tzinfo (1.2.10) thread_safe (~> 0.1) webdrivers (4.2.0) nokogiri (~> 1.6) rubyzip (>= 1.3.0) selenium-webdriver (>= 3.0, < 4.0) - websocket-driver (0.7.1) + websocket-driver (0.7.5) websocket-extensions (>= 0.1.0) - websocket-extensions (0.1.4) + websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) @@ -229,7 +232,8 @@ DEPENDENCIES react-rails! selenium-webdriver test-unit (~> 2.5) + turbolinks webdrivers BUNDLED WITH - 2.1.2 + 2.1.4 diff --git a/gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile.lock b/gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile.lock index e98701f7..dcb1a650 100644 --- a/gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile.lock +++ b/gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile.lock @@ -1,7 +1,7 @@ PATH remote: .. specs: - react-rails (2.6.1) + react-rails (2.6.2) babel-transpiler (>= 0.7.0) connection_pool execjs @@ -11,43 +11,43 @@ PATH GEM remote: http://rubygems.org/ specs: - actioncable (5.2.4.1) - actionpack (= 5.2.4.1) + actioncable (5.2.8.1) + actionpack (= 5.2.8.1) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailer (5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) + actionmailer (5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (5.2.4.1) - actionview (= 5.2.4.1) - activesupport (= 5.2.4.1) + actionpack (5.2.8.1) + actionview (= 5.2.8.1) + activesupport (= 5.2.8.1) rack (~> 2.0, >= 2.0.8) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.2) - actionview (5.2.4.1) - activesupport (= 5.2.4.1) + actionview (5.2.8.1) + activesupport (= 5.2.8.1) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.3) - activejob (5.2.4.1) - activesupport (= 5.2.4.1) + activejob (5.2.8.1) + activesupport (= 5.2.8.1) globalid (>= 0.3.6) - activemodel (5.2.4.1) - activesupport (= 5.2.4.1) - activerecord (5.2.4.1) - activemodel (= 5.2.4.1) - activesupport (= 5.2.4.1) + activemodel (5.2.8.1) + activesupport (= 5.2.8.1) + activerecord (5.2.8.1) + activemodel (= 5.2.8.1) + activesupport (= 5.2.8.1) arel (>= 9.0) - activestorage (5.2.4.1) - actionpack (= 5.2.4.1) - activerecord (= 5.2.4.1) - marcel (~> 0.3.1) - activesupport (5.2.4.1) + activestorage (5.2.8.1) + actionpack (= 5.2.8.1) + activerecord (= 5.2.8.1) + marcel (~> 1.0.0) + activesupport (5.2.8.1) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) @@ -84,19 +84,19 @@ GEM coffee-script-source execjs coffee-script-source (1.12.2) - concurrent-ruby (1.1.5) + concurrent-ruby (1.1.10) connection_pool (2.2.2) - crass (1.0.5) + crass (1.0.6) docile (1.1.5) - erubi (1.9.0) + erubi (1.11.0) es5-shim-rails (4.0.1) actionpack (>= 3.1) railties (>= 3.1) execjs (2.7.0) ffi (1.11.3) formatador (0.2.5) - globalid (0.4.2) - activesupport (>= 4.2.0) + globalid (0.6.0) + activesupport (>= 5.0) guard (2.16.1) formatador (>= 0.2.4) listen (>= 2.7, < 4.0) @@ -110,34 +110,33 @@ GEM guard-minitest (2.4.6) guard-compat (~> 1.2) minitest (>= 3.0) - i18n (1.7.0) + i18n (1.12.0) concurrent-ruby (~> 1.0) jbuilder (2.9.1) activesupport (>= 4.2.0) json (2.3.0) - libv8 (7.3.492.27.1-x86_64-darwin-18) + libv8 (7.3.492.27.1) listen (3.0.8) rb-fsevent (~> 0.9, >= 0.9.4) rb-inotify (~> 0.9, >= 0.9.7) - loofah (2.4.0) + loofah (2.18.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) lumberjack (1.0.13) mail (2.7.1) mini_mime (>= 0.1.1) - marcel (0.3.3) - mimemagic (~> 0.3.2) + marcel (1.0.2) method_source (0.9.2) - mimemagic (0.3.10) - mini_mime (1.0.2) - mini_portile2 (2.4.0) + mini_mime (1.1.2) + mini_portile2 (2.8.0) mini_racer (0.2.8) libv8 (>= 6.9.411) - minitest (5.13.0) + minitest (5.16.3) nenv (0.3.0) - nio4r (2.5.2) - nokogiri (1.10.7) - mini_portile2 (~> 2.4.0) + nio4r (2.5.8) + nokogiri (1.13.8) + mini_portile2 (~> 2.8.0) + racc (~> 1.4) notiffany (0.1.3) nenv (~> 0.1) shellany (~> 0.0) @@ -148,36 +147,37 @@ GEM byebug (~> 11.0) pry (~> 0.10) public_suffix (4.0.2) - rack (2.0.8) + racc (1.6.0) + rack (2.2.4) rack-proxy (0.6.5) rack rack-test (1.1.0) rack (>= 1.0, < 3) - rails (5.2.4.1) - actioncable (= 5.2.4.1) - actionmailer (= 5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) - activemodel (= 5.2.4.1) - activerecord (= 5.2.4.1) - activestorage (= 5.2.4.1) - activesupport (= 5.2.4.1) + rails (5.2.8.1) + actioncable (= 5.2.8.1) + actionmailer (= 5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) + activemodel (= 5.2.8.1) + activerecord (= 5.2.8.1) + activestorage (= 5.2.8.1) + activesupport (= 5.2.8.1) bundler (>= 1.3.0) - railties (= 5.2.4.1) + railties (= 5.2.8.1) sprockets-rails (>= 2.0.0) rails-dom-testing (2.0.3) activesupport (>= 4.2.0) nokogiri (>= 1.6) - rails-html-sanitizer (1.3.0) + rails-html-sanitizer (1.4.3) loofah (~> 2.3) - railties (5.2.4.1) - actionpack (= 5.2.4.1) - activesupport (= 5.2.4.1) + railties (5.2.8.1) + actionpack (= 5.2.8.1) + activesupport (= 5.2.8.1) method_source rake (>= 0.8.7) thor (>= 0.19.0, < 2.0) - rake (13.0.1) + rake (13.0.6) rb-fsevent (0.10.3) rb-inotify (0.10.1) ffi (~> 1.0) @@ -192,18 +192,21 @@ GEM json (>= 1.8, < 3) simplecov-html (~> 0.10.0) simplecov-html (0.10.2) - sprockets (4.0.0) + sprockets (4.1.1) concurrent-ruby (~> 1.0) rack (> 1, < 3) - sprockets-rails (3.2.1) - actionpack (>= 4.0) - activesupport (>= 4.0) + sprockets-rails (3.4.2) + actionpack (>= 5.2) + activesupport (>= 5.2) sprockets (>= 3.0.0) test-unit (2.5.5) - thor (1.0.1) + thor (1.2.1) thread_safe (0.3.6) tilt (2.0.10) - tzinfo (1.2.6) + turbolinks (5.2.1) + turbolinks-source (~> 5.2) + turbolinks-source (5.2.0) + tzinfo (1.2.10) thread_safe (~> 0.1) webdrivers (4.2.0) nokogiri (~> 1.6) @@ -213,9 +216,9 @@ GEM activesupport (>= 4.2) rack-proxy (>= 0.6.1) railties (>= 4.2) - websocket-driver (0.7.1) + websocket-driver (0.7.5) websocket-extensions (>= 0.1.0) - websocket-extensions (0.1.4) + websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) @@ -240,8 +243,9 @@ DEPENDENCIES selenium-webdriver test-unit (~> 2.5) therubyrhino + turbolinks webdrivers webpacker (~> 3.0) BUNDLED WITH - 2.1.2 + 2.1.4 diff --git a/gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile.lock b/gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile.lock index ade04364..a1150042 100644 --- a/gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile.lock +++ b/gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile.lock @@ -1,7 +1,7 @@ PATH remote: .. specs: - react-rails (2.6.1) + react-rails (2.6.2) babel-transpiler (>= 0.7.0) connection_pool execjs @@ -11,43 +11,43 @@ PATH GEM remote: http://rubygems.org/ specs: - actioncable (5.2.4.1) - actionpack (= 5.2.4.1) + actioncable (5.2.8.1) + actionpack (= 5.2.8.1) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailer (5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) + actionmailer (5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (5.2.4.1) - actionview (= 5.2.4.1) - activesupport (= 5.2.4.1) + actionpack (5.2.8.1) + actionview (= 5.2.8.1) + activesupport (= 5.2.8.1) rack (~> 2.0, >= 2.0.8) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.2) - actionview (5.2.4.1) - activesupport (= 5.2.4.1) + actionview (5.2.8.1) + activesupport (= 5.2.8.1) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.3) - activejob (5.2.4.1) - activesupport (= 5.2.4.1) + activejob (5.2.8.1) + activesupport (= 5.2.8.1) globalid (>= 0.3.6) - activemodel (5.2.4.1) - activesupport (= 5.2.4.1) - activerecord (5.2.4.1) - activemodel (= 5.2.4.1) - activesupport (= 5.2.4.1) + activemodel (5.2.8.1) + activesupport (= 5.2.8.1) + activerecord (5.2.8.1) + activemodel (= 5.2.8.1) + activesupport (= 5.2.8.1) arel (>= 9.0) - activestorage (5.2.4.1) - actionpack (= 5.2.4.1) - activerecord (= 5.2.4.1) - marcel (~> 0.3.1) - activesupport (5.2.4.1) + activestorage (5.2.8.1) + actionpack (= 5.2.8.1) + activerecord (= 5.2.8.1) + marcel (~> 1.0.0) + activesupport (5.2.8.1) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) @@ -84,19 +84,19 @@ GEM coffee-script-source execjs coffee-script-source (1.12.2) - concurrent-ruby (1.1.5) + concurrent-ruby (1.1.10) connection_pool (2.2.2) - crass (1.0.5) + crass (1.0.6) docile (1.1.5) - erubi (1.9.0) + erubi (1.11.0) es5-shim-rails (4.0.1) actionpack (>= 3.1) railties (>= 3.1) execjs (2.7.0) ffi (1.11.3) formatador (0.2.5) - globalid (0.4.2) - activesupport (>= 4.2.0) + globalid (0.6.0) + activesupport (>= 5.0) guard (2.16.1) formatador (>= 0.2.4) listen (>= 2.7, < 4.0) @@ -110,34 +110,33 @@ GEM guard-minitest (2.4.6) guard-compat (~> 1.2) minitest (>= 3.0) - i18n (1.7.0) + i18n (1.12.0) concurrent-ruby (~> 1.0) jbuilder (2.9.1) activesupport (>= 4.2.0) json (2.3.0) - libv8 (7.3.492.27.1-x86_64-darwin-18) + libv8 (7.3.492.27.1) listen (3.0.8) rb-fsevent (~> 0.9, >= 0.9.4) rb-inotify (~> 0.9, >= 0.9.7) - loofah (2.4.0) + loofah (2.18.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) lumberjack (1.0.13) mail (2.7.1) mini_mime (>= 0.1.1) - marcel (0.3.3) - mimemagic (~> 0.3.2) + marcel (1.0.2) method_source (0.9.2) - mimemagic (0.3.10) - mini_mime (1.0.2) - mini_portile2 (2.4.0) + mini_mime (1.1.2) + mini_portile2 (2.8.0) mini_racer (0.2.8) libv8 (>= 6.9.411) - minitest (5.13.0) + minitest (5.16.3) nenv (0.3.0) - nio4r (2.5.2) - nokogiri (1.10.7) - mini_portile2 (~> 2.4.0) + nio4r (2.5.8) + nokogiri (1.13.8) + mini_portile2 (~> 2.8.0) + racc (~> 1.4) notiffany (0.1.3) nenv (~> 0.1) shellany (~> 0.0) @@ -148,36 +147,37 @@ GEM byebug (~> 11.0) pry (~> 0.10) public_suffix (4.0.2) - rack (2.0.8) + racc (1.6.0) + rack (2.2.4) rack-proxy (0.6.5) rack rack-test (1.1.0) rack (>= 1.0, < 3) - rails (5.2.4.1) - actioncable (= 5.2.4.1) - actionmailer (= 5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) - activemodel (= 5.2.4.1) - activerecord (= 5.2.4.1) - activestorage (= 5.2.4.1) - activesupport (= 5.2.4.1) + rails (5.2.8.1) + actioncable (= 5.2.8.1) + actionmailer (= 5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) + activemodel (= 5.2.8.1) + activerecord (= 5.2.8.1) + activestorage (= 5.2.8.1) + activesupport (= 5.2.8.1) bundler (>= 1.3.0) - railties (= 5.2.4.1) + railties (= 5.2.8.1) sprockets-rails (>= 2.0.0) rails-dom-testing (2.0.3) activesupport (>= 4.2.0) nokogiri (>= 1.6) - rails-html-sanitizer (1.3.0) + rails-html-sanitizer (1.4.3) loofah (~> 2.3) - railties (5.2.4.1) - actionpack (= 5.2.4.1) - activesupport (= 5.2.4.1) + railties (5.2.8.1) + actionpack (= 5.2.8.1) + activesupport (= 5.2.8.1) method_source rake (>= 0.8.7) thor (>= 0.19.0, < 2.0) - rake (13.0.1) + rake (13.0.6) rb-fsevent (0.10.3) rb-inotify (0.10.1) ffi (~> 1.0) @@ -192,18 +192,21 @@ GEM json (>= 1.8, < 3) simplecov-html (~> 0.10.0) simplecov-html (0.10.2) - sprockets (4.0.0) + sprockets (4.1.1) concurrent-ruby (~> 1.0) rack (> 1, < 3) - sprockets-rails (3.2.1) - actionpack (>= 4.0) - activesupport (>= 4.0) + sprockets-rails (3.4.2) + actionpack (>= 5.2) + activesupport (>= 5.2) sprockets (>= 3.0.0) test-unit (2.5.5) - thor (1.0.1) + thor (1.2.1) thread_safe (0.3.6) tilt (2.0.10) - tzinfo (1.2.6) + turbolinks (5.2.1) + turbolinks-source (~> 5.2) + turbolinks-source (5.2.0) + tzinfo (1.2.10) thread_safe (~> 0.1) webdrivers (4.2.0) nokogiri (~> 1.6) @@ -213,9 +216,9 @@ GEM activesupport (>= 4.2) rack-proxy (>= 0.6.1) railties (>= 4.2) - websocket-driver (0.7.1) + websocket-driver (0.7.5) websocket-extensions (>= 0.1.0) - websocket-extensions (0.1.4) + websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) @@ -240,8 +243,9 @@ DEPENDENCIES selenium-webdriver test-unit (~> 2.5) therubyrhino + turbolinks webdrivers webpacker (~> 4.0) BUNDLED WITH - 2.1.2 + 2.1.4 diff --git a/gemfiles/rails_5.2_sprockets_3.gemfile.lock b/gemfiles/rails_5.2_sprockets_3.gemfile.lock index 7bd49e82..bda107d2 100644 --- a/gemfiles/rails_5.2_sprockets_3.gemfile.lock +++ b/gemfiles/rails_5.2_sprockets_3.gemfile.lock @@ -1,7 +1,7 @@ PATH remote: .. specs: - react-rails (2.6.1) + react-rails (2.6.2) babel-transpiler (>= 0.7.0) connection_pool execjs @@ -11,43 +11,43 @@ PATH GEM remote: http://rubygems.org/ specs: - actioncable (5.2.4.1) - actionpack (= 5.2.4.1) + actioncable (5.2.8.1) + actionpack (= 5.2.8.1) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailer (5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) + actionmailer (5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (5.2.4.1) - actionview (= 5.2.4.1) - activesupport (= 5.2.4.1) + actionpack (5.2.8.1) + actionview (= 5.2.8.1) + activesupport (= 5.2.8.1) rack (~> 2.0, >= 2.0.8) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.2) - actionview (5.2.4.1) - activesupport (= 5.2.4.1) + actionview (5.2.8.1) + activesupport (= 5.2.8.1) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.3) - activejob (5.2.4.1) - activesupport (= 5.2.4.1) + activejob (5.2.8.1) + activesupport (= 5.2.8.1) globalid (>= 0.3.6) - activemodel (5.2.4.1) - activesupport (= 5.2.4.1) - activerecord (5.2.4.1) - activemodel (= 5.2.4.1) - activesupport (= 5.2.4.1) + activemodel (5.2.8.1) + activesupport (= 5.2.8.1) + activerecord (5.2.8.1) + activemodel (= 5.2.8.1) + activesupport (= 5.2.8.1) arel (>= 9.0) - activestorage (5.2.4.1) - actionpack (= 5.2.4.1) - activerecord (= 5.2.4.1) - marcel (~> 0.3.1) - activesupport (5.2.4.1) + activestorage (5.2.8.1) + actionpack (= 5.2.8.1) + activerecord (= 5.2.8.1) + marcel (~> 1.0.0) + activesupport (5.2.8.1) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) @@ -84,19 +84,19 @@ GEM coffee-script-source execjs coffee-script-source (1.12.2) - concurrent-ruby (1.1.5) + concurrent-ruby (1.1.10) connection_pool (2.2.2) - crass (1.0.5) + crass (1.0.6) docile (1.1.5) - erubi (1.9.0) + erubi (1.11.0) es5-shim-rails (4.0.1) actionpack (>= 3.1) railties (>= 3.1) execjs (2.7.0) ffi (1.11.3) formatador (0.2.5) - globalid (0.4.2) - activesupport (>= 4.2.0) + globalid (0.6.0) + activesupport (>= 5.0) guard (2.16.1) formatador (>= 0.2.4) listen (>= 2.7, < 4.0) @@ -110,7 +110,7 @@ GEM guard-minitest (2.4.6) guard-compat (~> 1.2) minitest (>= 3.0) - i18n (1.7.0) + i18n (1.12.0) concurrent-ruby (~> 1.0) jbuilder (2.9.1) activesupport (>= 4.2.0) @@ -119,25 +119,24 @@ GEM listen (3.0.8) rb-fsevent (~> 0.9, >= 0.9.4) rb-inotify (~> 0.9, >= 0.9.7) - loofah (2.4.0) + loofah (2.18.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) lumberjack (1.0.13) mail (2.7.1) mini_mime (>= 0.1.1) - marcel (0.3.3) - mimemagic (~> 0.3.2) + marcel (1.0.2) method_source (0.9.2) - mimemagic (0.3.10) - mini_mime (1.0.2) - mini_portile2 (2.4.0) + mini_mime (1.1.2) + mini_portile2 (2.8.0) mini_racer (0.2.8) libv8 (>= 6.9.411) - minitest (5.13.0) + minitest (5.16.3) nenv (0.3.0) - nio4r (2.5.2) - nokogiri (1.10.7) - mini_portile2 (~> 2.4.0) + nio4r (2.5.8) + nokogiri (1.13.8) + mini_portile2 (~> 2.8.0) + racc (~> 1.4) notiffany (0.1.3) nenv (~> 0.1) shellany (~> 0.0) @@ -148,34 +147,35 @@ GEM byebug (~> 11.0) pry (~> 0.10) public_suffix (4.0.2) - rack (2.0.8) + racc (1.6.0) + rack (2.2.4) rack-test (1.1.0) rack (>= 1.0, < 3) - rails (5.2.4.1) - actioncable (= 5.2.4.1) - actionmailer (= 5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) - activemodel (= 5.2.4.1) - activerecord (= 5.2.4.1) - activestorage (= 5.2.4.1) - activesupport (= 5.2.4.1) + rails (5.2.8.1) + actioncable (= 5.2.8.1) + actionmailer (= 5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) + activemodel (= 5.2.8.1) + activerecord (= 5.2.8.1) + activestorage (= 5.2.8.1) + activesupport (= 5.2.8.1) bundler (>= 1.3.0) - railties (= 5.2.4.1) + railties (= 5.2.8.1) sprockets-rails (>= 2.0.0) rails-dom-testing (2.0.3) activesupport (>= 4.2.0) nokogiri (>= 1.6) - rails-html-sanitizer (1.3.0) + rails-html-sanitizer (1.4.3) loofah (~> 2.3) - railties (5.2.4.1) - actionpack (= 5.2.4.1) - activesupport (= 5.2.4.1) + railties (5.2.8.1) + actionpack (= 5.2.8.1) + activesupport (= 5.2.8.1) method_source rake (>= 0.8.7) thor (>= 0.19.0, < 2.0) - rake (13.0.1) + rake (13.0.6) rb-fsevent (0.10.3) rb-inotify (0.10.1) ffi (~> 1.0) @@ -193,26 +193,26 @@ GEM sprockets (3.7.2) concurrent-ruby (~> 1.0) rack (> 1, < 3) - sprockets-rails (3.2.1) - actionpack (>= 4.0) - activesupport (>= 4.0) + sprockets-rails (3.4.2) + actionpack (>= 5.2) + activesupport (>= 5.2) sprockets (>= 3.0.0) test-unit (2.5.5) - thor (1.0.1) + thor (1.2.1) thread_safe (0.3.6) tilt (2.0.10) turbolinks (5.2.1) turbolinks-source (~> 5.2) turbolinks-source (5.2.0) - tzinfo (1.2.6) + tzinfo (1.2.10) thread_safe (~> 0.1) webdrivers (4.2.0) nokogiri (~> 1.6) rubyzip (>= 1.3.0) selenium-webdriver (>= 3.0, < 4.0) - websocket-driver (0.7.1) + websocket-driver (0.7.5) websocket-extensions (>= 0.1.0) - websocket-extensions (0.1.4) + websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) @@ -242,4 +242,4 @@ DEPENDENCIES webdrivers BUNDLED WITH - 2.1.2 + 2.1.4 diff --git a/gemfiles/rails_5.2_sprockets_4.gemfile.lock b/gemfiles/rails_5.2_sprockets_4.gemfile.lock index 416342e0..9beb999f 100644 --- a/gemfiles/rails_5.2_sprockets_4.gemfile.lock +++ b/gemfiles/rails_5.2_sprockets_4.gemfile.lock @@ -1,7 +1,7 @@ PATH remote: .. specs: - react-rails (2.6.1) + react-rails (2.6.2) babel-transpiler (>= 0.7.0) connection_pool execjs @@ -11,43 +11,43 @@ PATH GEM remote: http://rubygems.org/ specs: - actioncable (5.2.4.1) - actionpack (= 5.2.4.1) + actioncable (5.2.8.1) + actionpack (= 5.2.8.1) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailer (5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) + actionmailer (5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (5.2.4.1) - actionview (= 5.2.4.1) - activesupport (= 5.2.4.1) + actionpack (5.2.8.1) + actionview (= 5.2.8.1) + activesupport (= 5.2.8.1) rack (~> 2.0, >= 2.0.8) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.2) - actionview (5.2.4.1) - activesupport (= 5.2.4.1) + actionview (5.2.8.1) + activesupport (= 5.2.8.1) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.0.3) - activejob (5.2.4.1) - activesupport (= 5.2.4.1) + activejob (5.2.8.1) + activesupport (= 5.2.8.1) globalid (>= 0.3.6) - activemodel (5.2.4.1) - activesupport (= 5.2.4.1) - activerecord (5.2.4.1) - activemodel (= 5.2.4.1) - activesupport (= 5.2.4.1) + activemodel (5.2.8.1) + activesupport (= 5.2.8.1) + activerecord (5.2.8.1) + activemodel (= 5.2.8.1) + activesupport (= 5.2.8.1) arel (>= 9.0) - activestorage (5.2.4.1) - actionpack (= 5.2.4.1) - activerecord (= 5.2.4.1) - marcel (~> 0.3.1) - activesupport (5.2.4.1) + activestorage (5.2.8.1) + actionpack (= 5.2.8.1) + activerecord (= 5.2.8.1) + marcel (~> 1.0.0) + activesupport (5.2.8.1) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) @@ -84,19 +84,19 @@ GEM coffee-script-source execjs coffee-script-source (1.12.2) - concurrent-ruby (1.1.5) + concurrent-ruby (1.1.10) connection_pool (2.2.2) - crass (1.0.5) + crass (1.0.6) docile (1.1.5) - erubi (1.9.0) + erubi (1.11.0) es5-shim-rails (4.0.1) actionpack (>= 3.1) railties (>= 3.1) execjs (2.7.0) ffi (1.11.3) formatador (0.2.5) - globalid (0.4.2) - activesupport (>= 4.2.0) + globalid (0.6.0) + activesupport (>= 5.0) guard (2.16.1) formatador (>= 0.2.4) listen (>= 2.7, < 4.0) @@ -110,7 +110,7 @@ GEM guard-minitest (2.4.6) guard-compat (~> 1.2) minitest (>= 3.0) - i18n (1.7.0) + i18n (1.12.0) concurrent-ruby (~> 1.0) jbuilder (2.9.1) activesupport (>= 4.2.0) @@ -119,27 +119,24 @@ GEM listen (3.0.8) rb-fsevent (~> 0.9, >= 0.9.4) rb-inotify (~> 0.9, >= 0.9.7) - loofah (2.4.0) + loofah (2.18.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) lumberjack (1.0.13) mail (2.7.1) mini_mime (>= 0.1.1) - marcel (0.3.3) - mimemagic (~> 0.3.2) + marcel (1.0.2) method_source (0.9.2) - mimemagic (0.3.10) - nokogiri (~> 1) - rake - mini_mime (1.0.2) - mini_portile2 (2.4.0) + mini_mime (1.1.2) + mini_portile2 (2.8.0) mini_racer (0.2.8) libv8 (>= 6.9.411) - minitest (5.13.0) + minitest (5.16.3) nenv (0.3.0) - nio4r (2.5.2) - nokogiri (1.10.7) - mini_portile2 (~> 2.4.0) + nio4r (2.5.8) + nokogiri (1.13.8) + mini_portile2 (~> 2.8.0) + racc (~> 1.4) notiffany (0.1.3) nenv (~> 0.1) shellany (~> 0.0) @@ -150,34 +147,35 @@ GEM byebug (~> 11.0) pry (~> 0.10) public_suffix (4.0.2) - rack (2.0.8) + racc (1.6.0) + rack (2.2.4) rack-test (1.1.0) rack (>= 1.0, < 3) - rails (5.2.4.1) - actioncable (= 5.2.4.1) - actionmailer (= 5.2.4.1) - actionpack (= 5.2.4.1) - actionview (= 5.2.4.1) - activejob (= 5.2.4.1) - activemodel (= 5.2.4.1) - activerecord (= 5.2.4.1) - activestorage (= 5.2.4.1) - activesupport (= 5.2.4.1) + rails (5.2.8.1) + actioncable (= 5.2.8.1) + actionmailer (= 5.2.8.1) + actionpack (= 5.2.8.1) + actionview (= 5.2.8.1) + activejob (= 5.2.8.1) + activemodel (= 5.2.8.1) + activerecord (= 5.2.8.1) + activestorage (= 5.2.8.1) + activesupport (= 5.2.8.1) bundler (>= 1.3.0) - railties (= 5.2.4.1) + railties (= 5.2.8.1) sprockets-rails (>= 2.0.0) rails-dom-testing (2.0.3) activesupport (>= 4.2.0) nokogiri (>= 1.6) - rails-html-sanitizer (1.3.0) + rails-html-sanitizer (1.4.3) loofah (~> 2.3) - railties (5.2.4.1) - actionpack (= 5.2.4.1) - activesupport (= 5.2.4.1) + railties (5.2.8.1) + actionpack (= 5.2.8.1) + activesupport (= 5.2.8.1) method_source rake (>= 0.8.7) thor (>= 0.19.0, < 2.0) - rake (13.0.1) + rake (13.0.6) rb-fsevent (0.10.3) rb-inotify (0.10.1) ffi (~> 1.0) @@ -192,29 +190,29 @@ GEM json (>= 1.8, < 3) simplecov-html (~> 0.10.0) simplecov-html (0.10.2) - sprockets (4.0.0) + sprockets (4.1.1) concurrent-ruby (~> 1.0) rack (> 1, < 3) - sprockets-rails (3.2.1) - actionpack (>= 4.0) - activesupport (>= 4.0) + sprockets-rails (3.4.2) + actionpack (>= 5.2) + activesupport (>= 5.2) sprockets (>= 3.0.0) test-unit (2.5.5) - thor (1.0.1) + thor (1.2.1) thread_safe (0.3.6) tilt (2.0.10) turbolinks (5.2.1) turbolinks-source (~> 5.2) turbolinks-source (5.2.0) - tzinfo (1.2.6) + tzinfo (1.2.10) thread_safe (~> 0.1) webdrivers (4.2.0) nokogiri (~> 1.6) rubyzip (>= 1.3.0) selenium-webdriver (>= 3.0, < 4.0) - websocket-driver (0.7.1) + websocket-driver (0.7.5) websocket-extensions (>= 0.1.0) - websocket-extensions (0.1.4) + websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) From f85685da8828eef90cf62716eae5a985dab54c69 Mon Sep 17 00:00:00 2001 From: Harry Bachrach Date: Sun, 11 Sep 2022 16:17:27 -0700 Subject: [PATCH 3/6] Fix Minitest handling of kwargs after update past 5.16.0 Issue was introduced in https://github.com/minitest/minitest/commit/6fecff9eeb136703130db83c0ef5960f9395b7de and hack workaround was introduced in https://github.com/minitest/minitest/commit/b8ddc4fa4457f82faacfe994c26980966959c48e I *think* that changing the API make this work w/o the workaround would require a breaking change so we can leave that for later. --- .github/workflows/ruby.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 21d167db..c3cc96a3 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -26,8 +26,12 @@ jobs: - rails_5.2_sprockets_3 - rails_5.2_sprockets_4 runs-on: ubuntu-latest - env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps + env: + # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile + # Workaround b/c upgrading Minitest broke some mocking expectations + # having to do with automatic kwarg splatting + MT_KWARGS_HACK: 1 steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 From dd2e249adfdc71f894e8911bbf4cac17e9bf524a Mon Sep 17 00:00:00 2001 From: Harry Bachrach Date: Sun, 11 Sep 2022 18:24:04 -0700 Subject: [PATCH 4/6] Drop end-of-life Ruby 2.5 from testing matrix This was EOLed over a year ago and doing a `bundle install` with the current set of packages gives > minitest-5.16.3 requires ruby version < 4.0, >= 2.6, which is > incompatible with the current version --- .github/workflows/ruby.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index c3cc96a3..9601f00a 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -15,7 +15,6 @@ jobs: ruby: - 2.7.0 - 2.6.5 - - 2.5.7 - jruby-9.1.17.0 gemfile: # These have webpacker: From 5f6062d979741508b12161c283c4b4aed1bf76da Mon Sep 17 00:00:00 2001 From: Harry Bachrach Date: Sun, 11 Sep 2022 21:46:32 -0700 Subject: [PATCH 5/6] Upgrade JRuby to 9.3 within testing matrix Unfortunately Bundler 2 and JRuby 9.1 are not compatible on GitHub actions (see here: https://github.com/ruby/setup-ruby/issues/108) which leads to failures. Additionally, due to the `webdrivers` gem as a testing dependency needing upgrading, 9.2 is also a no-go. JRuby 9.3 matches (MRI) Ruby 2.6 which we just made the floor of the testing matrix, so this is likely a good version to match anyhow. --- .github/workflows/ruby.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 9601f00a..0c1be434 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -15,7 +15,7 @@ jobs: ruby: - 2.7.0 - 2.6.5 - - jruby-9.1.17.0 + - jruby-9.3.7.0 gemfile: # These have webpacker: - rails_5.2_no_sprockets From 1c282a6684a0a567b09c0f2146f1bf6a2ea340ec Mon Sep 17 00:00:00 2001 From: Harry Bachrach Date: Wed, 14 Sep 2022 13:45:01 -0700 Subject: [PATCH 6/6] Temporarily drop testing against JRuby This is b/c therubyrhino isn't working properly in CI (see https://github.com/hibachrach/react-rails/actions/runs/3034813789/jobs/4884297309) --- .github/workflows/ruby.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 0c1be434..ae7d9557 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -15,7 +15,8 @@ jobs: ruby: - 2.7.0 - 2.6.5 - - jruby-9.3.7.0 + # TODO restore testing against JRuby w/ therubyrhino + # - jruby-9.3.7.0 gemfile: # These have webpacker: - rails_5.2_no_sprockets