React Rails Testing

[tmoney100]

I just updated to 1.3.0, ran rake test and got this error message:

ActionView::Template::Error: undefined method 'react_component' for nil:NilClass app/views/layouts/application.html.erb:30:in '_app_views_layouts_application_html_erb___3811361224884677630_70195218569900'

This only happens when I run my tests and doesn't happen when I run the code in the browser. When I stepped back to 1.2.0 it fixed the issue.

I'm calling react_component in my application.html.erb file.

[rmosolgo]

sounds like I broke something, hmm

[rmosolgo]

Ah, is this only in test. I think my implementation depends on Rack middleware doing its thing, let me find a fix for this ...

[rmosolgo]

could you share the test that's breaking? The tests in this repo pass but I guess there's another kind of test that I missed!

[tmoney100]

The most basic test that is failing is:

test '.show should succeed' do
    get :show
    assert_response :success
  end

[rmosolgo]

what kind of test is that? what test framework? is it inside a class which extends a base test class? is it part of a describe block?

[rmosolgo]

(seems like this middleware is not applied in the test context: https://github.com/reactjs/react-rails/blob/master/lib/react/rails/render_middleware.rb)

[tmoney100]

We use:

group :development, :test do
  # Call 'byebug' anywhere in the code to stop execution and get a debugger console
  gem 'byebug'

  # Shim to load environment variables from .env into ENV in development. Read more: https://github.com/bkeepers/dotenv
  gem 'dotenv-rails'

  # Letter opener: https://github.com/ryanb/letter_opener
  gem 'letter_opener', :group => :development

  # Headless phantomjs(chrome based browser) for javascrip testing
  gem 'poltergeist', :require => false

  # Ruby Pry, debug ruby https://github.com/deivid-rodriguez/pry-byebug
  gem 'pry-byebug'

  # Static syle checking https://github.com/bbatsov/rubocop
  # version 0.33.0 is causing issues -> when running autocomplete it find multiple infinite loops
  # Untill we solve that problem, we'll go back to the last stable version.
  gem 'rubocop', '0.32.1', :require => false

  # Optional code coverage
  gem 'simplecov', :require => false

  # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
  gem 'spring'

  # Javascript testing https://github.com/modeset/teaspoon
  gem 'teaspoon'
  gem 'teaspoon-mocha'
end

group :test do
  # Use webmock for integration testing.  Read more: https://github.com/bblimke/webmock
  gem 'webmock'
  gem 'mocha'
end

[stevestmartin]

@rmosolgo I can confirm this as well when upgrading to react-rails 1.3.0, this is using minitest 5.1 using a controller test extending from ActionController::TestCase

[rmosolgo]

Ahh awesome, thanks for that info, i can try to reproduce tomorrow!

[stevestmartin]

@rmosolgo I went ahead and sumitted a pull request for a failing testcase that reproduces this problem #355, hope this helps

[rmosolgo]

YES, that's super helpful, thank you!!

[rmosolgo]

@stevestmartin could you point your gemfile at this branch and give it a try? #356

for example,

gem 'react-rails', github: 'rmosolgo/react-rails', branch: 'refactor-helper-lifecycle'

[stevestmartin]

@rmosolgo works great, thanks. also using middleware was only temporarily a bad choice. Rails 5 controller tests will work the same as integration tests executing the middleware.

[rmosolgo]

Thanks for reporting & testing, please try 1.3.1 from rubygems and reopen if you still have this problem!

Good to know about middleware in the future, but I figure we'll be supporting Rails 4 for a few years still 😬