From a55ef7802032d167e0e2aa613f71b224d539ad90 Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Sun, 19 Oct 2014 19:01:00 +0530 Subject: [PATCH 1/3] - Enable emitting warnings by default --- Rakefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Rakefile b/Rakefile index 15f72adda..24f32a327 100644 --- a/Rakefile +++ b/Rakefile @@ -14,6 +14,7 @@ Rake::TestTask.new(:test) do |t| t.libs << 'test' t.pattern = ENV['TEST_PATTERN'] || 'test/**/*_test.rb' t.verbose = ENV['TEST_VERBOSE'] == '1' + t.warning = true end task default: :test From 007ef9f9d872b5b333b2e0108d941eddf190cd9c Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Sun, 19 Oct 2014 19:01:43 +0530 Subject: [PATCH 2/3] - `File.exists?` is deprecated, changed to use `File.exist?` instead. --- test/dummy/config/boot.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/dummy/config/boot.rb b/test/dummy/config/boot.rb index ef360470a..6266cfc50 100644 --- a/test/dummy/config/boot.rb +++ b/test/dummy/config/boot.rb @@ -1,5 +1,5 @@ # Set up gems listed in the Gemfile. ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__) -require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE']) +require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE']) $LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__) From 72c5078b6c713ad233485de06ae26e6e5582df29 Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Sun, 19 Oct 2014 19:02:39 +0530 Subject: [PATCH 3/3] - Fixed react renderer and view helper to not throw ambiguous arguments warnings, when asserting data using regex arguements. --- test/react_renderer_test.rb | 8 ++++---- test/view_helper_test.rb | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/test/react_renderer_test.rb b/test/react_renderer_test.rb index f01245a43..0cb2316da 100644 --- a/test/react_renderer_test.rb +++ b/test/react_renderer_test.rb @@ -4,8 +4,8 @@ class ReactRendererTest < ActiveSupport::TestCase test 'Server rendering class directly' do result = React::Renderer.render "TodoList", :todos => %w{todo1 todo2 todo3} - assert_match /todo1.*todo2.*todo3/, result - assert_match /data-react-checksum/, result + assert_match(/todo1.*todo2.*todo3/, result) + assert_match(/data-react-checksum/, result) end test 'Server rendering with an already-encoded json string' do @@ -14,8 +14,8 @@ class ReactRendererTest < ActiveSupport::TestCase end.target! result = React::Renderer.render "TodoList", json_string - assert_match /todo1.*todo2.*todo3/, result - assert_match /data-react-checksum/, result + assert_match(/todo1.*todo2.*todo3/, result) + assert_match(/data-react-checksum/, result) end test 'Rendering does not throw an exception when console log api is used' do diff --git a/test/view_helper_test.rb b/test/view_helper_test.rb index 7f3445528..f9e3166e7 100644 --- a/test/view_helper_test.rb +++ b/test/view_helper_test.rb @@ -94,14 +94,14 @@ class ViewHelperTest < ActionDispatch::IntegrationTest test 'react server rendering also gets mounted on client' do visit '/server/1' - assert_match /data-react-class=\"TodoList\"/, page.html - assert_match /data-react-checksum/, page.html - assert_match /yep/, page.find("#status").text + assert_match(/data-react-class=\"TodoList\"/, page.html) + assert_match(/data-react-checksum/, page.html) + assert_match(/yep/, page.find("#status").text) end test 'react server rendering does not include internal properties' do visit '/server/1' - assert_no_match /tag=/, page.html - assert_no_match /prerender=/, page.html + assert_no_match(/tag=/, page.html) + assert_no_match(/prerender=/, page.html) end end