Skip to content

Add test for destructuring assignments #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2015
Merged

Add test for destructuring assignments #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a83f4db
Add destructuring assignment example
hartator Feb 26, 2015
64c50f8
Add destructuring assigmenent test
hartator Feb 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/dummy/app/assets/javascripts/harmony_example.js.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@ var HarmonyComponent = React.createClass({
},
render: function(){
var greeting = HarmonyComponent.generateGreeting();
var { active, ...other } = { active: true, x: 1, y:2 }
return (
<h1 {...this.props}>{greeting}</h1>
<div>
<h1 {...this.props}>{greeting}</h1>
<div active={active}>
<span {...other} />
</div>
</div>
)
},
});
});
1 change: 1 addition & 0 deletions test/jsxtransform_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ class JSXTransformTest < ActionDispatch::IntegrationTest
assert_match(/generateGreeting:\s*function\(\)/, @response.body, "object literal methods")
assert_match(/React.__spread/, @response.body, "spreading props")
assert_match(/Your greeting is: '" \+ insertedGreeting \+ "'/, @response.body, "string interpolation")
assert_match(/active=\$__0\.active/, @response.body, "destructuring assignment")
end

test 'accepts strip_types: true option' do
Expand Down