Switch to the new Sprockets processor

[eugenijusr]

Starting version 4 Sprockets is removing the register_engine method which registers JSX transformers using Tilt based templates breaking this gem for the current Rails 5 master. This has been deprecated since Sprockets version 3:
https://github.com/rails/sprockets/blob/master/UPGRADING.md

This PR adds a JSX Processor and registers it via register_processor as application/jsx mime type. Is there a reserved mime type for JSX templates?

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

[rmosolgo]

Hmmm as you can see in the specs, this @output is getting assigned in the first use, but then never being reassigned. This causes all inputs to have the same output!

Is there a downside to simply

class Processor 
  def self.call(input)
    JSX::transform(input[:data])
  end 
end

?

[eugenijusr]

I think this was done for performance reasons in the Tilt template version of this. For these Sprocket processors there is a way to do a similar thing by implementing an optional cache_key method.

[rmosolgo]

Thanks for updating us!

I don't think there is a special mime type for .jsx. They're usually requested & served as JavaScript files, so I think the normal JS mime type is good enough!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[rmosolgo]

from https://github.com/rails/sprockets#return-hash:

Returning a String is shorthand for returning { data: str }

Can we return a string only? Do we need any metadata?

[rmosolgo]

✨ Thanks again for getting us up-to-date (and getting me up to date 😝) !