-
Notifications
You must be signed in to change notification settings - Fork 751
Snake-Case key to Camel-Case key for props when server render #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Hi! Thanks for adding this feature. I can see how useful this will be! How about making this an opt-in feature? I can think of two ways to make this opt-in:
I don't want to make it the default behavior for two reasons:
Thanks again, how does that sound? |
|
sounds good! I'll be modify the code. |
|
I have added a config option: MyApp::Application.configure do
config.react.camelize_props = true #default false
endplease review, thanks! |
|
🎉 thanks, this is great! |
Snake-Case key to Camel-Case key for props when server render
|
@rmosolgo thanks |
|
👍 |
This is a port of reactjs/react-rails#409
Camle-Case in es6.jsx:
I must be camle-case in Rails:
I think it's better in Rails: