Configure watched files after rails initializers have loaded #729
Conversation
|
👏 wow, thanks this looks great! let's see how CI likes it 😬 Nice to know I can have react-rails watch my |
|
Humm, lots of failures :( it's really hard to test this change as most of the methods for the active support file watchers are private and it's not possible to get any information about which files have been added to the watch list without accessing private data which is not consistent across all of the available file watchers. The only other option I can think of to test this is to create a mock file watcher object for the test. |
test/react/rails/railtie_test.rb
Outdated
| class RailtieTest < ActionDispatch::IntegrationTest | ||
| test "reloaders are configured after initializers are loaded" do | ||
| begin | ||
| @test_file = File.expand_path("../../dummy/app/pants", File.dirname(__FILE__)) |
There was a problem hiding this comment.
This file name, does it end in .js or .jsx? I think only those files are watched due to config.react.server_renderer_extensions. Could that be why the test doesn't pass?
There was a problem hiding this comment.
Good point, I'd forgotten about the file extension. Although some of the tests are passing and they passed locally which is odd as you would expect it not to pass at all. I'll check it out
kernow
force-pushed
the
load-watches-after-initializers
branch
from
958a2ed to
a213ca7
Compare
|
@rmosolgo this is much happier now. I assumed that all the builds would be passing on travis (before my changes) but it looks like there are several test that have not been passing on master. Is there anything else you want me to do on the PR? |
|
No, I have to figure those ones out separately! I'll cut a release soon, I'm hoping to merge one more fix... |
|
Finally shipped in 2.2.1! |
2 participants
Rails convention is now to load application config from initializers rather than
config/application.rb. This PR makes it possible to specifyserver_renderer_directories(amongst other settings) and have the settings honoured by the file watcher. Previously some settings configured in an initializer were ignored as the file watcher block was run before initializers were loaded.