Update javascript driver to headless chrome #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Wow, this actually doubles the build speed from 1h25 to 45 minutes for travis. |
Member
|
😍 So nice to get that download out of the CI build and put all the deps in the gemspec! |
Member
Author
|
The one 'hidden' dep is Chrome/Chromium itself. If we're happy with that (maybe I should document it) then we could merge this. |
Member
|
Yeah, if you add a doc, then big 👍 from me!
…On Sun, Oct 1, 2017 at 7:35 AM, Greg Myers ***@***.***> wrote:
The one 'hidden' dep is Chrome/Chromium itself. If we're happy with that
(maybe I should document it) then we could merge this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#796 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACIN1WeA2IVWG3iZxf4C_jqNF_nND9RFks5sn3kHgaJpZM4Ppt9c>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been having trouble installing the correct combinations of yarn, node (7.x), and phantomJS (2.1.1) to make the tests run smoothly on other computers. Even though I have the same versions, Cliver has decided not to load Phantom on certain machines.
Decided it would make developing this gem easier for other new people if everything they needed was in the Gemspec which you can do with headless chrome. Which is also the most up to date option.
Based on: https://robots.thoughtbot.com/headless-feature-specs-with-chrome and https://docs.travis-ci.com/user/gui-and-headless-browsers/