Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flicker problem in iphone6 plus #186

Closed
carrollcai opened this issue Jun 14, 2017 · 14 comments
Closed

flicker problem in iphone6 plus #186

carrollcai opened this issue Jun 14, 2017 · 14 comments
Labels
bug

Comments

@carrollcai
Copy link

@carrollcai carrollcai commented Jun 14, 2017

when i switched the tabs,the tabs background have a flicker in the whole tab area,the background is #333,the opacity is about 0.3.is iphone6 plus‘s trouble?

@danez

This comment has been minimized.

Copy link
Collaborator

@danez danez commented Jun 16, 2017

Can you post an example to look at? Without anything to look at I cannot answer.

@danez danez added the need feedback label Jun 16, 2017
@carrollcai

This comment has been minimized.

Copy link
Author

@carrollcai carrollcai commented Jun 22, 2017

its no flash in andorid,iphone had.i cant shot screen,its so fast,i will try change your code or use other tab

@carrollcai

This comment has been minimized.

Copy link
Author

@carrollcai carrollcai commented Jun 22, 2017

you can try in iphone6 or iphone6plus,i guess this problem also in iphone 6s.

@carrollcai

This comment has been minimized.

Copy link
Author

@carrollcai carrollcai commented Jun 22, 2017

i guess the focus operation have an influence on tab

@carrollcai

This comment has been minimized.

Copy link
Author

@carrollcai carrollcai commented Jun 22, 2017

@danez

This comment has been minimized.

Copy link
Collaborator

@danez danez commented Jun 22, 2017

I don't have an iphone, so I cannot test. If you can figure out what is the problem, feel free to create a PR.

@carrollcai

This comment has been minimized.

Copy link
Author

@carrollcai carrollcai commented Jun 23, 2017

thank you,if i have any question,i will quiz

@brunosantanarj

This comment has been minimized.

Copy link

@brunosantanarj brunosantanarj commented Aug 15, 2017

i am having the same problem, some solution ?

@JarrydTrokis

This comment has been minimized.

Copy link

@JarrydTrokis JarrydTrokis commented Feb 6, 2018

The fix is a simple CSS change:

Add the following line to the react tabs class
-webkit-tap-highlight-color: transparent;

@gaoqiang19514

This comment has been minimized.

Copy link

@gaoqiang19514 gaoqiang19514 commented Jun 16, 2018

@JarrydTrokis thank you very much!

@danez danez closed this in 0643a04 Jun 16, 2018
danez added a commit that referenced this issue Jun 16, 2018
@waynebloss

This comment has been minimized.

Copy link

@waynebloss waynebloss commented Aug 16, 2018

Any idea when this will be released?

@waynebloss

This comment has been minimized.

Copy link

@waynebloss waynebloss commented Aug 16, 2018

Actually, commit 5d608aa didn't fix this for me after I applied it manually by editing node_modules/react-tabs/style/react-tabs.css. I know that my manual edits got applied because I tried adding background-color: aqua to one of the selectors and I saw the change after re-starting my create-react-app dev server.

What finally did work for me was to add the following CSS to my local assets/css/styles.css:
(from stackoverflow)

* {
  -webkit-tap-highlight-color: transparent;
}

My main index.js file now looks like this:

import React from 'react';
import ReactDOM from 'react-dom';

import './assets/css/styles.css';
import 'react-tabs/style/react-tabs.css';

import App from './App';

ReactDOM.render(<App />, document.getElementById('root'));
@waynebloss

This comment has been minimized.

Copy link

@waynebloss waynebloss commented Aug 16, 2018

I'm on iPhone 6s with iOS 11.4 using Safari.

@danez danez reopened this Aug 30, 2018
@danez danez added bug and removed need feedback labels Aug 30, 2018
@danez

This comment has been minimized.

Copy link
Collaborator

@danez danez commented Aug 30, 2018

Fix now for real in 25cfa16

@danez danez closed this Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.